Review main Merged

15779[BUGFIX] swiftmaileradapter should ignore empty headers

Stefan Neufeind CR +2 V +2 Normal +64 −63 updated 06/03/13, 20:49

Commit message

Further processing empty header-values with
functions like parseAddress() can lead to
unexpected problems.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Philipp Gampe +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1

Files 1

Review log 13

  1. Stefan Neufeind commented on patch set 1 04/06/13, 15:32

    (1 inline comment)
    of course now also including 6.1

    Reply

    and now no 4.6 anymore
  2. Stefan Neufeind commented on patch set 1 04/06/13, 15:32

    ping
  3. Stefan Neufeind commented on patch set 1 04/06/13, 15:32

    (1 inline comment) Looking forward to some final review, please!
  4. Anja Leichsenring commented on patch set 1 04/06/13, 15:32

    Verified; Looks good to me, but someone else must approve
  5. Tomita Militaru commented on patch set 1 04/06/13, 15:32

    Verified; Looks good to me, but someone else must approve
  6. Mr. Jenkins commented on patch set 1 04/06/13, 15:32

  7. Wouter Wolters commented on patch set 1 04/06/13, 15:32

    Looks good to me, but someone else must approve Looks okay by reading
  8. Philipp Gampe commented on patch set 2 04/06/13, 15:32

    Looks good to me, but someone else must approve
  9. Mr. Jenkins commented on patch set 2 04/06/13, 15:32

  10. Wouter Wolters commented on patch set 2 04/06/13, 15:32

    Verified; Looks good to me, but someone else must approve
  11. Wouter Wolters uploaded patch set 2 04/06/13, 15:32

  12. Christian Kuhn commented on patch set 2 V 0 04/06/13, 15:32

    by team member; Looks good to me, approved
  13. Christian Kuhn merged patch set 3 04/06/13, 15:32