1589[FEATURE] Add possibility to have record-based uploadFolders
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 24
-
Andreas Wolf commented on patch set 2 2 comments 12/19/11, 18:49
I would prefer that you didn't submit this See my two comments. Apart from that the patch looks good. -
Mario Rimann commented on patch set 2 12/19/11, 18:49
I would prefer that you didn't submit this Please add the comment (see my inline comment) then it looks fine to me.class.t3lib_tcemain.php:1584please add a comment on what's done here exactly -
Mario Rimann commented on patch set 2 12/19/11, 18:49
(1 inline comment) -
Björn Pedersen commented on patch set 2 1 comment 12/19/11, 18:49
Looks good to me, but someone else must approve Except for a minor question the code looks good to me. -
Dmitry Dulepov commented on patch set 3 12/19/11, 18:49
We can simply specify that in the documentation: ###REC_FILED_UID### should not be used. That's all. -
Dmitry Dulepov uploaded patch set 3 12/19/11, 18:49
-
Dmitry Dulepov commented on patch set 3 12/19/11, 18:49
Changes from version 2: - use mkdir_deep instead of mkdir (for example, if you want to use a structure like uploads/tx_yourext/###REC_FIELD_pid###/###REC_FIELD_username###) - always check for dir existance (helps when you installed the ext but forgot to create the upload dir (just a small goodie) -
Stefan Neufeind commented on patch set 2 12/19/11, 18:49
Looks good to me, but someone else must approve -
Stefan Neufeind commented on patch set 2 12/19/11, 18:49
Steffen, please have a look at the comments: Imho this looks to me like it's almost through. And it would be great to have it in. -
Stefan Neufeind commented on patch set 3 12/19/11, 18:49
Looks good to me, but someone else must approve -
Oliver Hader uploaded patch set 4 12/19/11, 18:49
-
Oliver Hader commented on patch set 4 12/19/11, 18:49
Fails; I would prefer that you didn't submit this I understand the reasons of not having thousands of files in one single directory. However I doubt, that this is the correct approach to have a fragmentation of the filesystem. I'd rather opt to have several hooks in place that could take care of individual processing and tossing to directories then. When the file abstraction layer comes to live, this will be handled by a layer then - so no need to put that into TCEmain at this time. Sorry... Besides that: I guess a dedicated field of a record (which might be changable) defines where to put those files accordant to your patch. Let's assume the types are "video", "images" and "documents". Now imagine the following: * ####REC_FIELD_THETYPE### reflects those mentioned three types * there's a record with type "video" and two files * the record gets modified to type "documents", the previous files removed and new files added * the old files won't be removed from the "video" directory since it's not known anymore at the record That why I've chosen the -1 on verify as well. -
Oliver Hader commented on patch set 4 12/19/11, 18:49
Looks good to me, but someone else must approve Rebasing to master V:0, R:1 V:0, R:1 from Stefan Neufeind <typo3.neufeind@speedpartner.de> -
Steffen Ritter uploaded patch set 2 12/19/11, 18:49
class.t3lib_tceforms.php:2218Replyit would, but I just omitted it here, because we do not need an extra database acces to get the data and I'm not sure if the substituteMarkerArray itself would not hurt in case of speedclass.t3lib_tcemain.php:1584ReplyHow about: // For performance reasons just process markers and field replacement when there it's really neededclass.t3lib_tcemain.php:1585ReplyEven if you look at a deleted record (f.e. recycler, history of pages etc) this information might be needed. At least I think if an infomration from an deleted records is requested at TCEmain (wherever) it should be retourned completely. Furthermore when we quey for an uid, i think we can ommit the deleted in sence of "speed" -
Steffen Ritter commented on patch set 2 12/19/11, 18:49
(3 inline comments) -
Steffen Ritter commented on patch set 3 12/19/11, 18:49
Fails I know that I created this one, but I also encountered an conceptional bug: ###REC_UID### is not set for new records... Therefore the images go to the wrong folder... If any one finds an brillians solution for this - great - until then, I cannot support merging a buggy feature. -
Steffen Ritter commented on patch set 3 12/19/11, 18:49
No score fine removing my -1 -
Philipp Gampe commented on patch set 4 12/19/11, 18:49
Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 12/19/11, 18:49
Build Successful SUCCESS: http://ci.typo3.org/job/typo3-v4-core-gerrit/273/ -
Mr. Jenkins commented on patch set 2 12/19/11, 18:49
Build Successful SUCCESS: http://ci.typo3.org/job/typo3-v4-core-gerrit/274/ -
Mr. Jenkins commented on patch set 3 12/19/11, 18:49
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2536/ : SUCCESS -
Mr. Jenkins commented on patch set 4 12/19/11, 18:49
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2630/ : SUCCESS -
Dominik Mathern commented on patch set 4 12/19/11, 18:49
Verified; Looks good to me, but someone else must approve -
Steffen Ritter commented on patch set 4 12/19/11, 18:49
Abandoned FAL changes the file-relation stuff anyhow...