15980[TASK] Add possibility for a custom TCA TreeProvider
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Helmut Hummel +1
-
Verified V +2
- Georg Ringer +2
- Helmut Hummel +1
Issues 1
Files 2
Review log 22
-
Helmut Hummel commented on patch set 1 11/05/12, 06:34
(1 inline comment) +1 for the ideaTreeDataProviderFactory.php:53If you put the above line in an else part of the check if a dataProvider is configured, I'm fine with this change going into 6.0 -
Helmut Hummel commented on patch set 1 11/05/12, 06:34
not sure if this can go in TYPO3 versions below 6.0, I tend to say no. -
Helmut Hummel uploaded patch set 2 11/05/12, 06:34
-
Helmut Hummel uploaded patch set 3 11/05/12, 06:34
-
Helmut Hummel commented on patch set 4 11/05/12, 06:34
Verified; Looks good to me, but someone else must approve -
Helmut Hummel uploaded patch set 4 11/05/12, 06:34
-
Georg Ringer commented on patch set 4 11/05/12, 06:34
Verified; Looks good to me, but someone else must approve -
Helmut Hummel commented on patch set 5 11/05/12, 06:34
I would prefer that you didn't submit this accidental patchset 5, please push patchset 4 again -
Helmut Hummel uploaded patch set 6 11/05/12, 06:34
-
Helmut Hummel uploaded patch set 7 11/05/12, 06:34
-
Helmut Hummel commented on patch set 7 11/05/12, 06:34
Verified; Looks good to me, but someone else must approve -
Georg Ringer uploaded patch set 5 11/05/12, 06:34
-
Georg Ringer commented on patch set 7 V 0 11/05/12, 06:34
by team member; Looks good to me, approved -
Georg Ringer commented on patch set 7 11/05/12, 06:34
can be get that in? ;) -
Mr. Jenkins commented on patch set 1 11/05/12, 06:34
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6421/ : SUCCESS -
Mr. Jenkins commented on patch set 2 11/05/12, 06:34
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6422/ : FAILURE -
Mr. Jenkins commented on patch set 3 11/05/12, 06:34
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6423/ : FAILURE -
Mr. Jenkins commented on patch set 4 11/05/12, 06:34
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6424/ : SUCCESS -
Mr. Jenkins commented on patch set 5 11/05/12, 06:34
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6451/ : SUCCESS -
Mr. Jenkins commented on patch set 6 11/05/12, 06:34
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6455/ : SUCCESS -
Mr. Jenkins commented on patch set 7 11/05/12, 06:34
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6456/ : SUCCESS -
Georg Ringer merged patch set 7 11/05/12, 06:34