Review main Merged

16013[BUGFIX] Fix handling of additionalHeaderData in USER_INT

Helmut Hummel CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

While introducing USER_INT handling for the pageRenderer
a bug has been introduced which breaks traditional usage of
additionalHeaderData and additionalFooterData.

This is the case because the replacement of the headerData is done
first, when the to be replaced strings are not present
in the HTML content.
They are stored in the pageRenderer context.

Because of that, we need to replace the pageRenderer marker first
and after that the marker for additionalHeaderData
and additionalFooterData

Review

  • Code review CR +2
    • Helmut Hummel +2
  • Verified V +2
    • Helmut Hummel +2

Files 1

Review log 3

  1. Helmut Hummel commented on patch set 1 V 0 10/29/12, 16:11

    by team member; Looks good to me, approved
  2. Mr. Jenkins commented on patch set 1 10/29/12, 16:11

  3. Helmut Hummel merged patch set 1 10/29/12, 16:11