16088[BUGFIX] Update LocalConfiguration fails
Commit message
Review
-
Code review CR -1
- Helmut Hummel +2
- Wouter Wolters +1
- Dmitry Dulepov -1
- Christian Kuhn +1
-
Verified V +2
- Helmut Hummel +2
- Christian Kuhn +1
Files 1
Review log 19
-
Dmitry Dulepov uploaded patch set 3 11/02/12, 20:18
-
Dmitry Dulepov commented on patch set 3 11/02/12, 20:18
Looks good to me, but someone else must approve Function "touch" is better here. And there is no need for @ before is_file because it does not throw warnings if the file does not exist. We do want warnings in all other cases though. -
Helmut Hummel commented on patch set 2 11/02/12, 20:18
(1 inline comment)LocalConfigurationUpdate.php:116can't we just use GeneralUtility::writeFile() here? -
Christian Kuhn commented on patch set 2 11/02/12, 20:18
+1 to fix this in update wizard itself, and let the config handler untouched. -
Mattias Nilsson commented on patch set 3 11/02/12, 20:18
Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 2 11/02/12, 20:18
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6473/ : SUCCESS -
Mr. Jenkins commented on patch set 3 11/02/12, 20:18
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6488/ : SUCCESS -
Wouter Wolters commented on patch set 3 11/02/12, 20:18
Looks good to me, but someone else must approve -
Nicole Hummel uploaded patch set 2 11/02/12, 20:18
-
Nicole Hummel commented on patch set 3 11/02/12, 20:18
I would prefer that you didn't submit this As we discussed it's better to use the GeneralUtility function to write the file. I would like that more because this function is unit tested. Will upload the new patch in a few minutes -
Dmitry Dulepov commented on patch set 4 11/02/12, 20:18
I would prefer that you didn't submit this I do not see much sense in writing an empty file in a more complicated way. A call to touch() would be sufficient and more readable. Calling writeFile() with empty string just causes questions. In fact, we may simply modify writeLocalConfiguration() to skip is_file() check. Also writeLocalConfiguration is static but it is called dynamically. May be it should be fixed too. -
Helmut Hummel commented on patch set 4 V 0 11/02/12, 20:18
by team member; Looks good to me, approved -
Christian Kuhn commented on patch set 4 11/02/12, 20:18
I prefer the usage of GeneralUtility::writeFile() at this point, it is also used in writeLocalConfiguration() and takes care of permissions and such. Still +1 on the patch from me. -
Christian Kuhn commented on patch set 4 11/02/12, 20:18
Verified; Looks good to me, but someone else must approve -
Christian Kuhn commented on patch set 4 11/02/12, 20:18
writeLocalConfiguration() is not static (anymore). -
Mr. Jenkins commented on patch set 4 11/02/12, 20:18
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6492/ : SUCCESS -
Wouter Wolters commented on patch set 4 11/02/12, 20:18
Looks good to me, but someone else must approve -
Nicole Hummel uploaded patch set 4 11/02/12, 20:18
-
Helmut Hummel merged patch set 4 11/02/12, 20:18