Review main Merged

16102[BUGFIX] Failure in AbstractRepository::findByUid on deleted record

Oliver Hader CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

Resource\AbstractRepository::findByUid fails if the record to
be fetched has been deleted or simply does not exist. The
condition whether something was fetched from database is wrong.

count(FALSE) is TRUE, thus it needs to be ensure that there is
a non-empty array.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Helmut Hummel +2
  • Verified V +2
    • Oliver Hader +2
    • Helmut Hummel +2

Files 1

Review log 16

  1. Oliver Klee commented on patch set 1 11/02/12, 20:24

    (1 inline comment)
  2. Oliver Klee commented on patch set 1 11/02/12, 20:24

    (1 inline comment)
  3. Oliver Klee uploaded patch set 2 11/02/12, 20:24

  4. Oliver Klee commented on patch set 2 11/02/12, 20:24

    Looks good to me, but someone else must approve I've also fixed the exception (which included "$this->table" instead of the table name).
  5. Oliver Hader commented on patch set 1 11/02/12, 20:24

    (1 inline comment) Please read commit messages and try to understand the problem before posting "-1" reviews... Thanks. You can easily test this one with the media module (which is related in the Forge ticket, if you already had a look there).
  6. Oliver Hader commented on patch set 1 11/02/12, 20:24

    (1 inline comment)
  7. Oliver Hader commented on patch set 1 11/02/12, 20:24

    (1 inline comment)
  8. Oliver Hader commented on patch set 2 1 comment 11/02/12, 20:24

    I would prefer that you didn't submit this
  9. Oliver Hader uploaded patch set 3 11/02/12, 20:24

  10. Helmut Hummel commented on patch set 3 V 0 11/02/12, 20:24

    by team member; Looks good to me, approved
  11. Steffen Ritter commented on patch set 1 11/02/12, 20:24

    (1 inline comment) not a -1 but a question about the sense of making 2 checks - see inline comment

    AbstractRepository.php:192

    getSingleRow will return NULL if noe record is found. so the easiest and most performant way would be $row === NULL
  12. Mr. Jenkins commented on patch set 1 11/02/12, 20:24

  13. Mr. Jenkins commented on patch set 2 11/02/12, 20:24

  14. Mr. Jenkins commented on patch set 3 11/02/12, 20:24

  15. Oliver Hader commented on patch set 3 V 0 11/02/12, 20:24

    by team member; Looks good to me, approved Gettings things done... let's discuss about other topics, like translation of FAL records i.e.
  16. Oliver Hader merged patch set 3 11/02/12, 20:24