16102[BUGFIX] Failure in AbstractRepository::findByUid on deleted record
Commit message
Review
-
Code review CR +2
- Oliver Hader +2
- Helmut Hummel +2
-
Verified V +2
- Oliver Hader +2
- Helmut Hummel +2
Files 1
Review log 16
-
Oliver Klee commented on patch set 1 11/02/12, 20:24
(1 inline comment) -
Oliver Klee commented on patch set 1 11/02/12, 20:24
(1 inline comment) -
Oliver Klee uploaded patch set 2 11/02/12, 20:24
-
Oliver Klee commented on patch set 2 11/02/12, 20:24
Looks good to me, but someone else must approve I've also fixed the exception (which included "$this->table" instead of the table name). -
Oliver Hader commented on patch set 1 11/02/12, 20:24
(1 inline comment) Please read commit messages and try to understand the problem before posting "-1" reviews... Thanks. You can easily test this one with the media module (which is related in the Forge ticket, if you already had a look there). -
Oliver Hader commented on patch set 1 11/02/12, 20:24
(1 inline comment) -
Oliver Hader commented on patch set 1 11/02/12, 20:24
(1 inline comment) -
Oliver Hader commented on patch set 2 1 comment 11/02/12, 20:24
I would prefer that you didn't submit this -
Oliver Hader uploaded patch set 3 11/02/12, 20:24
-
Helmut Hummel commented on patch set 3 V 0 11/02/12, 20:24
by team member; Looks good to me, approved -
Steffen Ritter commented on patch set 1 11/02/12, 20:24
(1 inline comment) not a -1 but a question about the sense of making 2 checks - see inline commentAbstractRepository.php:192getSingleRow will return NULL if noe record is found. so the easiest and most performant way would be $row === NULL -
Mr. Jenkins commented on patch set 1 11/02/12, 20:24
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6494/ : SUCCESS -
Mr. Jenkins commented on patch set 2 11/02/12, 20:24
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6527/ : SUCCESS -
Mr. Jenkins commented on patch set 3 11/02/12, 20:24
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6530/ : SUCCESS -
Oliver Hader commented on patch set 3 V 0 11/02/12, 20:24
by team member; Looks good to me, approved Gettings things done... let's discuss about other topics, like translation of FAL records i.e. -
Oliver Hader merged patch set 3 11/02/12, 20:24