Review main Merged

16141[TASK] Speed up salted password unit test

Christian Kuhn CR +2 V +2 Easy +0 −27 updated 06/03/13, 20:49

Commit message

The patch removes tests in blowfish and phpass salting classes that
test maximum iteration count returns a valid salt. The underlying
salt code is slow by design, so the tests also take ages. The
functionality itself is already covered by the minimum salt count
test as well, thus - after speaking with Marcus Krause - we decided
to remove them without substitution to reduce the unit test suite
runtime.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2