Review main Merged

16223[TASK] Improve rendering of non existent content types

Georg Ringer CR +2 V +2 Easy +11 −4 updated 06/03/13, 20:49

Commit message

If a custom content element is created by using
an extension and the ext is removed, an empty content
element is rendered in the page module.

Now the same warning is shown as if a non existent
plugin is rendered

Review

  • Code review CR +2
    • Georg Ringer +2
    • Wouter Wolters +1
    • Nicole Hummel +1
    • Philipp Gampe +1
  • Verified V +2
    • Georg Ringer +2
    • Nicole Hummel +1
    • Philipp Gampe +1

Issues 1

Files 1

Review log 8

  1. Georg Ringer commented on patch set 1 11/09/12, 04:38

    no it is more as it also outputs a warning if the ctype is not available anymore because the extension has been removed
  2. Philipp Gampe commented on patch set 1 11/09/12, 04:38

    Verified; Looks good to me, but someone else must approve Thanks for taking care :)
  3. Mr. Jenkins commented on patch set 1 11/09/12, 04:38

  4. Wouter Wolters commented on patch set 1 11/09/12, 04:38

    Looks good to me, but someone else must approve
  5. Wouter Wolters commented on patch set 1 11/09/12, 04:38

  6. Nicole Hummel commented on patch set 1 11/09/12, 04:38

    Verified; Looks good to me, but someone else must approve I just abandoned my patch as it was already resolved by one of yours.
  7. Georg Ringer commented on patch set 1 V 0 11/09/12, 04:38

    by team member; Looks good to me, approved
  8. Georg Ringer merged patch set 1 11/09/12, 04:38