16280[BUGFIX] Fix problem with saving extension configuration in different tabs
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Stefan Neufeind +1
- Jan-Erik Revsbech +1
- Sebastian Michaelsen +1
- Wouter Wolters +1
- Mattias Nilsson +1
- Francois Suter +1
-
Verified V +2
- Christian Kuhn +2
- Stefan Neufeind +1
- Jan-Erik Revsbech +1
- Sebastian Michaelsen +1
- Wouter Wolters +1
- Mattias Nilsson +1
- Francois Suter +1
Files 2
Review log 14
-
Jan-Erik Revsbech uploaded patch set 2 01/25/13, 19:39
-
Jan-Erik Revsbech commented on patch set 3 01/25/13, 19:39
Verified; Looks good to me, but someone else must approve -
Jan-Erik Revsbech uploaded patch set 3 01/25/13, 19:39
-
Francois Suter commented on patch set 3 01/25/13, 19:39
Verified; Looks good to me, but someone else must approve Works fine and is cleaner than what I proposed later (https://review.typo3.org/#/c/17621/). -
Stefan Neufeind commented on patch set 3 01/25/13, 19:39
Verified; Looks good to me, but someone else must approve Seems to make sense by reading. Testcase works. -
Christian Kuhn commented on patch set 3 V 0 01/25/13, 19:39
by team member; Looks good to me, approved Thx, this patch is long overdue to merge. I have some nitpicks in the unit test, but will push a new issue for that (instead of a patch version) to not loose all the positive reviews in the commit message. -
Sebastian Michaelsen commented on patch set 3 01/25/13, 19:39
Verified; Looks good to me, but someone else must approve -
Mattias Nilsson commented on patch set 3 01/25/13, 19:39
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 01/25/13, 19:39
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6590/ : FAILURE -
Mr. Jenkins commented on patch set 2 01/25/13, 19:39
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6591/ : SUCCESS -
Mr. Jenkins commented on patch set 3 01/25/13, 19:39
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6592/ : SUCCESS -
Wouter Wolters commented on patch set 3 01/25/13, 19:39
Tested with unit test -
Wouter Wolters commented on patch set 3 01/25/13, 19:39
Verified; Looks good to me, but someone else must approve -
Christian Kuhn merged patch set 4 01/25/13, 19:39