Review main Merged

16280[BUGFIX] Fix problem with saving extension configuration in different tabs

Jan-Erik Revsbech CR +2 V +2 Normal +103 −5 updated 06/03/13, 20:49

Commit message

The new ConfigurationUtility is working internally with configuration as
valued array, but the existing configuration is serialized in the old
nested format. When merging these two, exising configuration was not
merged correctly, resulting in error where configuration set in other tabs
was lost when saving.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Jan-Erik Revsbech +1
    • Sebastian Michaelsen +1
    • Wouter Wolters +1
    • Mattias Nilsson +1
    • Francois Suter +1
  • Verified V +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Jan-Erik Revsbech +1
    • Sebastian Michaelsen +1
    • Wouter Wolters +1
    • Mattias Nilsson +1
    • Francois Suter +1

Files 2

Review log 14

  1. Jan-Erik Revsbech uploaded patch set 2 01/25/13, 19:39

  2. Jan-Erik Revsbech commented on patch set 3 01/25/13, 19:39

    Verified; Looks good to me, but someone else must approve
  3. Jan-Erik Revsbech uploaded patch set 3 01/25/13, 19:39

  4. Francois Suter commented on patch set 3 01/25/13, 19:39

    Verified; Looks good to me, but someone else must approve Works fine and is cleaner than what I proposed later (https://review.typo3.org/#/c/17621/).
  5. Stefan Neufeind commented on patch set 3 01/25/13, 19:39

    Verified; Looks good to me, but someone else must approve Seems to make sense by reading. Testcase works.
  6. Christian Kuhn commented on patch set 3 V 0 01/25/13, 19:39

    by team member; Looks good to me, approved Thx, this patch is long overdue to merge. I have some nitpicks in the unit test, but will push a new issue for that (instead of a patch version) to not loose all the positive reviews in the commit message.
  7. Sebastian Michaelsen commented on patch set 3 01/25/13, 19:39

    Verified; Looks good to me, but someone else must approve
  8. Mattias Nilsson commented on patch set 3 01/25/13, 19:39

    Verified; Looks good to me, but someone else must approve
  9. Mr. Jenkins commented on patch set 1 01/25/13, 19:39

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6590/ : FAILURE
  10. Mr. Jenkins commented on patch set 2 01/25/13, 19:39

  11. Mr. Jenkins commented on patch set 3 01/25/13, 19:39

  12. Wouter Wolters commented on patch set 3 01/25/13, 19:39

    Tested with unit test
  13. Wouter Wolters commented on patch set 3 01/25/13, 19:39

    Verified; Looks good to me, but someone else must approve
  14. Christian Kuhn merged patch set 4 01/25/13, 19:39