Review main Merged

16368[BUGFIX] Fix userfunc paths in EXT:saltedpasswords ext_conf_template.txt

Tilo Baller CR +2 V +2 Easy +6 −6 updated 06/03/13, 20:49

Commit message

Paths to the class files and class names for the user functions used
in the extension configuration of EXT:saltedpasswords are wrong, since
they were moved and namespaced.

Thus opening the extension configuration in extension manager fails
with a fatal error, because the required class files can not be loaded.

Load the right classes.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Tilo Baller +1
    • Mattias Nilsson +1
    • Philipp Gampe +1
  • Verified V +2
    • Christian Kuhn +2
    • Tilo Baller +1
    • Philipp Gampe +1

Files 1

Review log 9

  1. Philipp Gampe commented on patch set 1 11/13/12, 11:29

    Fails no options are shown, will have a look into this
  2. Christian Kuhn commented on patch set 2 V 0 11/13/12, 11:29

    by team member; Looks good to me, approved +1 The hash method option labels are still empty, but that could be handled in another issue. Thanks for the patch. Merged.
  3. Philipp Gampe uploaded patch set 2 11/13/12, 11:29

  4. Philipp Gampe commented on patch set 2 11/13/12, 11:29

    Verified; Looks good to me, but someone else must approve I fixed the paths and slightly edited the commit message.
  5. Mattias Nilsson commented on patch set 2 11/13/12, 11:29

    Looks good to me, but someone else must approve
  6. Mr. Jenkins commented on patch set 1 11/13/12, 11:29

  7. Mr. Jenkins commented on patch set 2 11/13/12, 11:29

  8. Tilo Baller commented on patch set 2 11/13/12, 11:29

    Verified; Looks good to me, but someone else must approve
  9. Christian Kuhn merged patch set 2 11/13/12, 11:29