Review main Abandoned

16403[BUGFIX] Missing action button to delete a file

Rico Sonntag CR 0 V 0 Normal +114 −3 updated 06/03/13, 20:49

Commit message

This commit adds a delete button to the file list.
Clicking it opens a confirmation dialog.
When confirmed, the file gets directly deleted from storage.

Review

  • Code review CR 0
  • Verified V 0

Files 2

Review log 25

  1. Mr. Jenkins commented on patch set 1 04/01/13, 13:25

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6630/ : FAILURE
  2. Dmitry Dulepov commented on patch set 2 04/01/13, 13:25

    Do not submit Sorry but the functionality is not of the quality we expect from TYPO3. It should be fully implemented: with warnings and reload of the list.
  3. Mattias Nilsson commented on patch set 2 04/01/13, 13:25

    Verified; Looks good to me, but someone else must approve
  4. Mr. Jenkins commented on patch set 2 04/01/13, 13:25

  5. Wouter Wolters commented on patch set 2 04/01/13, 13:25

    Looks good to me, but someone else must approve 2 small nitpicks
    missing Releases: 6.0

    FileList.php:657

    One space between type and comment
  6. Rico Sonntag uploaded patch set 2 04/01/13, 13:25

  7. Stefan Neufeind commented on patch set 3 04/01/13, 13:25

    (1 inline comment)
  8. Stefan Neufeind commented on patch set 3 04/01/13, 13:25

    (1 inline comment)
  9. Helmut Hummel commented on patch set 3 04/01/13, 13:25

    @Dmitry: I agree that the implementation is wrong, but a -2 vote would only fit, if you would disagree with adding a delete button in the file list (which I assume is not the case)
  10. Helmut Hummel commented on patch set 3 1 comment 04/01/13, 13:25

    Fails; I would prefer that you didn't submit this The way this is implemented is wrong. Only the indexed record is deleted not the actual file.
  11. Steffen Ritter commented on patch set 3 04/01/13, 13:25

    Do not submit The delete action should definitely delete the file in the file system - if and only if no existing relations to the file are present. The file list will always show all files present in file system and won't show files which are only present in the database
  12. Steffen Ritter commented on patch set 3 04/01/13, 13:25

    @Philip FAL has been refactored and tested quite some times during the years. This is the final result which works with remote files, too (it's actually defined by the driver) FAL is not DAM. they may share goals and targets but concepts are different - on purpose. You may not compare with Dam and try to change it accordingly.
  13. Christian Weiske commented on patch set 3 04/01/13, 13:25

    bq. FAL is not DAM. they may share goals and targets but concepts are different - on purpose. Is a trash feature wanted in FAL? Why does the context menu delete the file only, but not the sys_file record in database?
  14. Christian Weiske commented on patch set 3 04/01/13, 13:25

    No score; No score What is the correct method to delete a file in TYPO3 6.0? Currently we have several existing ways: 1. Use the context menu to delete it. This deletes the file, but keeps the database record as it is; it does not even set the "deleted" field 2. Edit meta data, click the "delete record" button. This sets the deleted field to 1, but keeps the file - so that you can restore it from trash. This patch here implements version 2, which is in line with the delete button on the meta data edit page.
  15. Christian Weiske commented on patch set 3 04/01/13, 13:25

    Helmut & Dimity, please have a look at Philipp Gampe's answer to my question on this issue: http://lists.typo3.org/pipermail/typo3-dev/2013-January/046148.html According to him, marking the record as deleted is the correct solution - while deleting the file (as the context menu does) is not the best way. The delete button behavior implemented by this patch would be correct then. What do you think?
  16. Christian Weiske commented on patch set 3 04/01/13, 13:25

    Verified; Looks good to me, but someone else must approve Deleting files from the file list works now.
  17. Steffen Ritter commented on patch set 4 04/01/13, 13:25

    Will abandon this patch-set in 24h as the issues has been fixed in another patch-set already in the meantime. see https://review.typo3.org/#/c/19240 https://review.typo3.org/#/c/19155/
  18. Christian Weiske uploaded patch set 4 04/01/13, 13:25

  19. Christian Weiske commented on patch set 4 04/01/13, 13:25

    Dmitry, could you review the change again? Your issues are covered now.
  20. Philipp Gampe commented on patch set 3 04/01/13, 13:25

    @Steffen that is not really the best behavior. Of course I would also want a delete a file finally, but I also sometimes just want to remove if from all references and to remove any link to it from frontend. Please do not think in terms of local files here, because FAL is not (only) about local files!
  21. Mattias Nilsson commented on patch set 3 04/01/13, 13:25

    Verified; Looks good to me, but someone else must approve
  22. Mr. Jenkins commented on patch set 3 04/01/13, 13:25

  23. Mr. Jenkins commented on patch set 4 04/01/13, 13:25

  24. Rico Sonntag uploaded patch set 3 04/01/13, 13:25

  25. Steffen Ritter commented on patch set 4 04/01/13, 13:25

    Abandoned already solved