Review main Merged

16462[BUGFIX] GeneralUtility::validEmail() can throw warnings

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

If GeneralUtility::validEmail() is called with array or object
as parameter, warnings or errors are thrown of type "strlen()
expects parameter 1 to be string" or similar.
The patch sanitizes the method by returning early with FALSE if
input parameter is not a string.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Helmut Hummel +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Helmut Hummel +1

Files 2

Review log 5

  1. Helmut Hummel commented on patch set 1 11/15/12, 21:50

    Verified; Looks good to me, but someone else must approve
  2. Mr. Jenkins commented on patch set 1 11/15/12, 21:50

  3. Wouter Wolters commented on patch set 1 11/15/12, 21:50

    Verified; Looks good to me, but someone else must approve
  4. Christian Kuhn commented on patch set 1 V 0 11/15/12, 21:50

    by team member; Looks good to me, approved
  5. Christian Kuhn merged patch set 1 11/15/12, 21:50