1649[BUGFIX] Wrong type hinting in interface tslib_menu_filterMenuPagesHook
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Steffen Gebert +1
-
Verified V +2
- Christian Kuhn +2
- Steffen Gebert +1
Issues 1
Files 1
Review log 6
-
Christian Kuhn commented on patch set 2 V 0 04/19/11, 21:13
by team member; Looks good to me, approved Obvious: The other menu classes (tmenu, jsmenu, ..) extend tslib_menu, so type hinting for the hook in tslib_menu should be bound to tslib_menu, and not just some extending class. -
Steffen Gebert commented on patch set 2 04/19/11, 21:13
Verified; Looks good to me, but someone else must approve -
Steffen Gebert uploaded patch set 2 04/19/11, 21:13
-
Mr. Jenkins commented on patch set 1 04/19/11, 21:13
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/301/ : SUCCESS -
Mr. Jenkins commented on patch set 2 04/19/11, 21:13
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/303/ : SUCCESS -
Christian Kuhn merged patch set 2 04/19/11, 21:13