Review main Merged

16502[BUGFIX] Extension Manager doesn't care about configuration sorting

Nicole Hummel CR +2 V +2 Normal +97 −5 updated 06/03/13, 20:49

Commit message

When showing the configuration of an extension actually the Extension
Manager doesn't care about the given sorting. This is because there is
only a merging of configuration arrays.

After merging we have to take care of the value in 'subcat' key and sort
each subcategorie by those values.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Stefan Neufeind +1
    • Wouter Wolters +1
    • Philipp Gampe +1
  • Verified V +2
    • Helmut Hummel +2
    • Stefan Neufeind +1
    • Wouter Wolters +1
    • Philipp Gampe +1

Files 2

Review log 17

  1. Mr. Jenkins commented on patch set 1 11/26/12, 22:47

  2. Stefan Neufeind commented on patch set 2 11/26/12, 22:47

    How can this be tested? How do you display the "configuration of extensions" where these subcategories are displayed?

    ConfigurationItemRepository.php:94

    one less tab for 6.0+
  3. Stefan Neufeind commented on patch set 2 1 comment 11/26/12, 22:47

    Verified; Looks good to me, but someone else must approve
  4. Christian Kuhn commented on patch set 2 11/26/12, 22:47

    test needed ...
  5. Philipp Gampe commented on patch set 2 11/26/12, 22:47

    Verified; Looks good to me, but someone else must approve A unit test would be really cool. You can test this with saltedpasswords.
  6. Mr. Jenkins commented on patch set 2 11/26/12, 22:47

  7. Nicole Hummel uploaded patch set 2 11/26/12, 22:47

  8. Mr. Jenkins commented on patch set 3 11/26/12, 22:47

  9. Nicole Hummel uploaded patch set 3 11/26/12, 22:47

  10. Stefan Neufeind commented on patch set 4 11/26/12, 22:47

    Verified; Looks good to me, but someone else must approve
  11. Philipp Gampe commented on patch set 4 11/26/12, 22:47

    Verified; Looks good to me, but someone else must approve
  12. Mr. Jenkins commented on patch set 4 11/26/12, 22:47

  13. Wouter Wolters commented on patch set 4 11/26/12, 22:47

    Verified; Looks good to me, but someone else must approve
  14. Nicole Hummel uploaded patch set 4 11/26/12, 22:47

  15. Nicole Hummel commented on patch set 4 11/26/12, 22:47

    To be able to test the function I had to change the function a bit. The return is an array now and the conversion to object happens in caller.
  16. Helmut Hummel commented on patch set 4 V 0 11/26/12, 22:47

    by team member; Looks good to me, approved
  17. Helmut Hummel merged patch set 4 11/26/12, 22:47