16502[BUGFIX] Extension Manager doesn't care about configuration sorting
Commit message
Review
-
Code review CR +2
- Helmut Hummel +2
- Stefan Neufeind +1
- Wouter Wolters +1
- Philipp Gampe +1
-
Verified V +2
- Helmut Hummel +2
- Stefan Neufeind +1
- Wouter Wolters +1
- Philipp Gampe +1
Files 2
Review log 17
-
Mr. Jenkins commented on patch set 1 11/26/12, 22:47
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6658/ : SUCCESS -
Stefan Neufeind commented on patch set 2 11/26/12, 22:47
How can this be tested? How do you display the "configuration of extensions" where these subcategories are displayed?ConfigurationItemRepository.php:94one less tab for 6.0+ -
Stefan Neufeind commented on patch set 2 1 comment 11/26/12, 22:47
Verified; Looks good to me, but someone else must approve -
Christian Kuhn commented on patch set 2 11/26/12, 22:47
test needed ... -
Philipp Gampe commented on patch set 2 11/26/12, 22:47
Verified; Looks good to me, but someone else must approve A unit test would be really cool. You can test this with saltedpasswords. -
Mr. Jenkins commented on patch set 2 11/26/12, 22:47
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6661/ : SUCCESS -
Nicole Hummel uploaded patch set 2 11/26/12, 22:47
-
Mr. Jenkins commented on patch set 3 11/26/12, 22:47
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6759/ : SUCCESS -
Nicole Hummel uploaded patch set 3 11/26/12, 22:47
-
Stefan Neufeind commented on patch set 4 11/26/12, 22:47
Verified; Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 4 11/26/12, 22:47
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 4 11/26/12, 22:47
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6760/ : SUCCESS -
Wouter Wolters commented on patch set 4 11/26/12, 22:47
Verified; Looks good to me, but someone else must approve -
Nicole Hummel uploaded patch set 4 11/26/12, 22:47
-
Nicole Hummel commented on patch set 4 11/26/12, 22:47
To be able to test the function I had to change the function a bit. The return is an array now and the conversion to object happens in caller. -
Helmut Hummel commented on patch set 4 V 0 11/26/12, 22:47
by team member; Looks good to me, approved -
Helmut Hummel merged patch set 4 11/26/12, 22:47