16503[BUGFIX] Default behaviour for field rendering of configuration is dropped
Commit message
Review
-
Code review CR -1
- Helmut Hummel +2
- Dmitry Dulepov -1
- Jigal van Hemert +1
-
Verified V +2
- Helmut Hummel +2
- Jigal van Hemert +1
Files 1
Review log 12
-
Helmut Hummel commented on patch set 1 11/20/12, 18:07
(1 inline comment)Hm, should we really do this? If we do so, we should throw a deprecation warning.; -> :TypoScriptConstantsViewHelper.php:77throw deprecation warning here :) -
Helmut Hummel commented on patch set 1 11/20/12, 18:07
(2 inline comments) -
Mr. Jenkins commented on patch set 1 11/20/12, 18:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6659/ : SUCCESS -
Dmitry Dulepov commented on patch set 2 1 comment 11/20/12, 18:07
I would prefer that you didn't submit this The patch works but there is a piece of code, which does not belong to the patch. Therefore I put -1 on purely this reason. Otherwise it would +2. -
Helmut Hummel commented on patch set 2 V 0 11/20/12, 18:07
by team member; Looks good to me, approved -
Jigal van Hemert commented on patch set 2 11/20/12, 18:07
Verified; Looks good to me, but someone else must approveTypoScriptConstantsViewHelper.php:213ReplyThe support for "input" and other undocumented types was added to keep existing extensions working. But because these types were never documented and thus never officially supported they are also deprecated and will be removed with the next version. -
Jigal van Hemert commented on patch set 2 11/20/12, 18:07
(1 inline comment) -
Mr. Jenkins commented on patch set 2 11/20/12, 18:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6672/ : SUCCESS -
Nicole Hummel uploaded patch set 2 11/20/12, 18:07
TypoScriptConstantsViewHelper.php:213ReplyThis is the code which throws the deprecation warning to remove unsupported types with 6.1 This was asked by other reviewers and IMHO is needed to drop it. -
Nicole Hummel commented on patch set 2 11/20/12, 18:07
I think we should drop it instantly but with deprecation warning we can remove it with next release. -
Nicole Hummel commented on patch set 2 11/20/12, 18:07
(1 inline comment) -
Helmut Hummel merged patch set 2 11/20/12, 18:07