Review main Merged

16503[BUGFIX] Default behaviour for field rendering of configuration is dropped

Nicole Hummel CR -1 V +2 Easy +9 −1 updated 06/03/13, 20:49

Commit message

In TYPO3 4.7 (and below) the default field of a configuration was a text
field. With a wrong configuration type in ext_conf_template.txt now the
field isn't rendered any more. There should be a fallback to a normal
input field like it used to.

Review

  • Code review CR -1
    • Helmut Hummel +2
    • Dmitry Dulepov -1
    • Jigal van Hemert +1
  • Verified V +2
    • Helmut Hummel +2
    • Jigal van Hemert +1

Files 1

Review log 12

  1. Helmut Hummel commented on patch set 1 11/20/12, 18:07

    (1 inline comment)
    Hm, should we really do this? If we do so, we should throw a deprecation warning.
    ; -> :

    TypoScriptConstantsViewHelper.php:77

    throw deprecation warning here :)
  2. Helmut Hummel commented on patch set 1 11/20/12, 18:07

    (2 inline comments)
  3. Mr. Jenkins commented on patch set 1 11/20/12, 18:07

  4. Dmitry Dulepov commented on patch set 2 1 comment 11/20/12, 18:07

    I would prefer that you didn't submit this The patch works but there is a piece of code, which does not belong to the patch. Therefore I put -1 on purely this reason. Otherwise it would +2.
  5. Helmut Hummel commented on patch set 2 V 0 11/20/12, 18:07

    by team member; Looks good to me, approved
  6. Jigal van Hemert commented on patch set 2 11/20/12, 18:07

    Verified; Looks good to me, but someone else must approve

    TypoScriptConstantsViewHelper.php:213 Reply

    The support for "input" and other undocumented types was added to keep existing extensions working. But because these types were never documented and thus never officially supported they are also deprecated and will be removed with the next version.
  7. Jigal van Hemert commented on patch set 2 11/20/12, 18:07

    (1 inline comment)
  8. Mr. Jenkins commented on patch set 2 11/20/12, 18:07

  9. Nicole Hummel uploaded patch set 2 11/20/12, 18:07

    TypoScriptConstantsViewHelper.php:213 Reply

    This is the code which throws the deprecation warning to remove unsupported types with 6.1 This was asked by other reviewers and IMHO is needed to drop it.
  10. Nicole Hummel commented on patch set 2 11/20/12, 18:07

    I think we should drop it instantly but with deprecation warning we can remove it with next release.
  11. Nicole Hummel commented on patch set 2 11/20/12, 18:07

    (1 inline comment)
  12. Helmut Hummel merged patch set 2 11/20/12, 18:07