Review main Merged

16599[BUGFIX] Activating NULL value field does not work with blank string

Oliver Hader CR +2 V +2 Normal +206 −5 updated 06/03/13, 20:49

Commit message

Activating a field that supports NULL values and just using a
blank string ("") does not work. The problem is a strcmp() call
that returns a false-positive on comparing NULL to blank strings

Review

  • Code review CR +2
    • Oliver Hader +2
  • Verified V +2
    • Oliver Hader +2

Files 2

Review log 4

  1. Oliver Hader uploaded patch set 2 11/20/12, 13:28

  2. Mr. Jenkins commented on patch set 1 11/20/12, 13:28

  3. Oliver Hader commented on patch set 2 V 0 11/20/12, 13:28

    by team member; Looks good to me, approved
  4. Oliver Hader merged patch set 2 11/20/12, 13:28