Review main Merged

16657[BUGFIX] Fix header thumbnail for new inserted records

Helmut Hummel CR +2 V +2 Easy +17 −16 updated 06/03/13, 20:49

Commit message

The header thumbnail is not correctly rendered when
inserting new images because the code tries to fetch
the record which is not created yet.

Use the data of the temporary record instead, to be able to 
correctly create the thumbnail in the header.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Stefan Neufeind +1
    • Wouter Wolters +1
    • Anja Leichsenring +1
  • Verified V +2
    • Helmut Hummel +2
    • Wouter Wolters +1
    • Anja Leichsenring +1

Files 1

Review log 8

  1. Stefan Neufeind commented on patch set 1 11/21/12, 22:47

    Looks good to me, but someone else must approve Looks okay at first sight (just reading).

    InlineElement.php:542

    Just for readability: Maybe split out the last part into a separate $fieldName and use $rec[$fieldName]? Could then also be used in the empty-condition.

    InlineElement.php:543

    Okay. I wasn't sure whether array_shift directly on a function-return without intermediate variable already worked in PHP 5.3 (I know it does in 5.4). But it does.
  2. Helmut Hummel commented on patch set 1 11/21/12, 22:47

    (2 inline comments)

    InlineElement.php:542 Reply

    yeah, but not critical here.

    InlineElement.php:543 Reply

    thanks for checking, I also did ;)
  3. Anja Leichsenring voted on patch set 1 V 0 11/21/12, 22:47

  4. Anja Leichsenring commented on patch set 1 11/21/12, 22:47

    Looks good to me, but someone else must approve
  5. Mr. Jenkins commented on patch set 1 11/21/12, 22:47

  6. Wouter Wolters commented on patch set 1 11/21/12, 22:47

    Verified; Looks good to me, but someone else must approve
  7. Helmut Hummel commented on patch set 1 V 0 11/21/12, 22:47

    by team member; Looks good to me, approved
  8. Helmut Hummel merged patch set 1 11/21/12, 22:47