16657[BUGFIX] Fix header thumbnail for new inserted records
Commit message
Review
-
Code review CR +2
- Helmut Hummel +2
- Stefan Neufeind +1
- Wouter Wolters +1
- Anja Leichsenring +1
-
Verified V +2
- Helmut Hummel +2
- Wouter Wolters +1
- Anja Leichsenring +1
Files 1
Review log 8
-
Stefan Neufeind commented on patch set 1 11/21/12, 22:47
Looks good to me, but someone else must approve Looks okay at first sight (just reading).InlineElement.php:542Just for readability: Maybe split out the last part into a separate $fieldName and use $rec[$fieldName]? Could then also be used in the empty-condition.InlineElement.php:543Okay. I wasn't sure whether array_shift directly on a function-return without intermediate variable already worked in PHP 5.3 (I know it does in 5.4). But it does. -
Helmut Hummel commented on patch set 1 11/21/12, 22:47
(2 inline comments)InlineElement.php:542Replyyeah, but not critical here.InlineElement.php:543Replythanks for checking, I also did ;) -
Anja Leichsenring voted on patch set 1 V 0 11/21/12, 22:47
-
Anja Leichsenring commented on patch set 1 11/21/12, 22:47
Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 11/21/12, 22:47
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6750/ : SUCCESS -
Wouter Wolters commented on patch set 1 11/21/12, 22:47
Verified; Looks good to me, but someone else must approve -
Helmut Hummel commented on patch set 1 V 0 11/21/12, 22:47
by team member; Looks good to me, approved -
Helmut Hummel merged patch set 1 11/21/12, 22:47