Review main Merged

16690[BUGFIX] IRRE creates new records when using foreign_selector

Kai Richter CR +2 V +2 Easy +1 −1 updated 01/09/14, 17:33

Commit message

This patch links existing child records correctly to the parent IRRE
field when selecting it in the generated dropdown.

Scenario:

Parent table configuration:
====================================================
[...]['columns']['irreField']['config'] = array(
  'type' => 'inline',
  'foreign_table' => 'childTable',
  'foreign_selector' => 'childSelector',
);

Child table configuration:
====================================================
[...]['columns'][childSelector']['config'] = array(
  'type' => 'select',
  'foreign_table' => 'childTable',
);

What happens?
====================================================
1. The parent IRRE field renders a dropdown field
   before the child records
2. Selecting one of the items in the dropdown should
   link this child record to current IRRE field
3. Without patch, it will only create a blank child
   record
4. Using the patch, it will link the existing child
   to the parent IRRE field

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1