Review main Merged

16722[BUGFIX] Use correct parameter type in insertPositionIcon

Jigal van Hemert CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

PagePositionMap::printContentElementsColumns must call insertPositionIcon
with fake row array instead of empty string as first parameter.

Review

  • Code review CR +2
    • Jigal van Hemert +2
  • Verified V +2
    • Jigal van Hemert +2

Files 1

Review log 4

  1. Mr. Jenkins commented on patch set 1 11/25/12, 11:56

  2. Jigal van Hemert commented on patch set 1 V 0 11/25/12, 11:56

    by team member; Looks good to me, approved Merged as no-brainer.
  3. Jigal van Hemert merged patch set 1 11/25/12, 11:56

  4. Jigal van Hemert commented on patch set 1 11/25/12, 12:20

    Reverted This patchset was reverted in change: I03c5aa86d3ef07dab5a9de9f4c59f1c3b3fb9a48