Review main Merged

16832[BUGFIX] ClassLoader error after installing extension

Oliver Hader CR +2 V +2 Easy +18 −3 updated 06/03/13, 20:49

Commit message

When e.g. installing tt_news version 3.4.0 (compatible to
TYPO3 CMS 6.0.0) a fatal error will be shown since tt_news
uses a class in ext_tables.php that requires the autoloader's
registry information.

The following happens on installing an extension:
* flushing the caches (including the class loader cache)
* redirecting to list view of extension manager
* triggering shutdown method in ClassLoader
* updating cache if $cacheUpdateRequired is set

This updates the autoloader registry with old data since
the extension's ext_autoload.php has not been considered at
that time.

The issue is fixed by explicitly reloading the ClassLoader
cache after TYPO3_LOADED_EXT has been reloaded.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
  • Verified V +2
    • Christian Kuhn +2
    • Stefan Neufeind +1

Files 3

Review log 13

  1. Stefan Neufeind commented on patch set 1 11/30/12, 16:35

    Verified; Looks good to me, but someone else must approve Seems to make sense by reading. Tried and works for me.
  2. Thomas Maroschik commented on patch set 1 11/30/12, 16:35

    I would prefer that you didn't submit this I analyzed the bug and found the real issue. It's that TYPO3_LOADED_EXT does is not reloaded properly, so if the ClassLoader would try to load the tt_news extPath it does not get resolved. Will post a proper fix soon.
  3. Thomas Maroschik uploaded patch set 2 11/30/12, 16:35

  4. Thomas Maroschik uploaded patch set 3 11/30/12, 16:35

  5. Stefan Neufeind commented on patch set 4 11/30/12, 16:35

    Verified; Looks good to me, but someone else must approve double-checked it's broken without the patch, fixed with the patch and broken again upon switching back to master
  6. Christian Kuhn commented on patch set 4 V 0 11/30/12, 16:35

    by team member; Looks good to me, approved
  7. Thomas Maroschik uploaded patch set 4 11/30/12, 16:35

  8. Philipp Gampe commented on patch set 1 11/30/12, 16:35

    Verified; Looks good to me, but someone else must approve
  9. Mr. Jenkins commented on patch set 1 11/30/12, 16:35

  10. Mr. Jenkins commented on patch set 2 11/30/12, 16:35

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6933/ : FAILURE
  11. Mr. Jenkins commented on patch set 3 11/30/12, 16:35

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6934/ : FAILURE
  12. Mr. Jenkins commented on patch set 4 11/30/12, 16:35

  13. Christian Kuhn merged patch set 4 11/30/12, 16:35