Review main Merged

16908[BUGFIX] Wrong category assignment in sys_note

Wouter Wolters CR +2 V +2 Easy +6 −8 updated 06/03/13, 20:49

Commit message

Wrong category assignment in sys_note. For example select the
"to-do" category and save the note. After saving the category is
called "Template"

Review

  • Code review CR +2
    • Georg Ringer +2
    • Stefan Neufeind +1
  • Verified V +2
    • Georg Ringer +2

Files 3

Review log 13

  1. Christian Kuhn commented on patch set 1 12/02/12, 09:49

    I would prefer that you didn't submit this now the icons in page + list are messed.
  2. Philipp Gampe commented on patch set 1 12/02/12, 09:49

    Verified; Looks good to me, but someone else must approve
  3. Mr. Jenkins commented on patch set 1 12/02/12, 09:49

  4. Stefan Neufeind commented on patch set 2 12/02/12, 09:49

    Verified; Looks good to me, but someone else must approve Confirmed. Works fine with the patch. Just create a note and view it in the page-module. Without the patch category is not what was selected before. Patch fixes that.
  5. Stefan Neufeind commented on patch set 2 12/02/12, 09:49

    I would prefer that you didn't submit this I checked with the values in a 4.6-installation. I guess it might make sense to keep the values that existed in the past to ease upgrade etc.? Or is there any reason to "renumber"? In 4.6 the category "Notes" had number 3 which was also used here before your patch but you change it to 2. Imho we should instead fix the display in locallang and style instead - but keep numeric values of the categories (by name).
  6. Christian Kuhn commented on patch set 2 12/02/12, 09:49

    Stefan is right here, we should keep existing vars and handle them correctly.
  7. Mr. Jenkins commented on patch set 2 12/02/12, 09:49

  8. Wouter Wolters uploaded patch set 2 12/02/12, 09:49

  9. Stefan Neufeind commented on patch set 3 12/02/12, 09:49

    Looks good to me, but someone else must approve checked it is fine by reading now. Taken from a 4.6-install and compared against the values here: <option value="1">Instructions</option> <option value="3">Notes</option> <option value="4">To-do</option> <option value="2">Template</option>
  10. Mr. Jenkins commented on patch set 3 12/02/12, 09:49

  11. Wouter Wolters uploaded patch set 3 12/02/12, 09:49

  12. Georg Ringer commented on patch set 3 V 0 12/02/12, 09:49

    by team member; Looks good to me, approved
  13. Georg Ringer merged patch set 3 12/02/12, 09:49