Review TYPO3_4-7 Merged 16980[BUGFIX] INTincScript_loadJSCode() causes PHP warnings Dmitry Dulepov CR +2 V +2 Easy +20 −9 updated 06/03/13, 20:49 Open in Gerrit Commit message Show more This function uses implode() on several variables without properly checking if they are actually arrays. This might cause PHP warnings. Change-Id: Ib2381586dd01682db0b1951b3fd1e9355cf727d4 Fixes: #32278 Releases: 6.1, 6.0, 4.7, 4.6, 4.5 Reviewed-on: https://review.typo3.org/16980 Reviewed-by: Falk Kühnel Reviewed-by: Dmitry Dulepov Tested-by: Dmitry Dulepov Review Code review CR +2 Dmitry Dulepov +2 Falk Kühnel +1 Verified V +2 Dmitry Dulepov +2 Files 1 typo3/sysext/cms/tslib/class.tslib_fe.php+20 −9 Review log 3 Falk Kühnel commented on patch set 1 12/20/12, 08:59 Looks good to me, but someone else must approve Dmitry Dulepov commented on patch set 1 V 0 12/20/12, 08:59 by team member; Looks good to me, approved Dmitry Dulepov merged patch set 2 12/20/12, 08:59