Review TYPO3_4-7 Merged

16980[BUGFIX] INTincScript_loadJSCode() causes PHP warnings

Dmitry Dulepov CR +2 V +2 Easy +20 −9 updated 06/03/13, 20:49

Commit message

This function uses implode() on several variables without properly
checking if they are actually arrays.
This might cause PHP warnings.

Review

  • Code review CR +2
    • Dmitry Dulepov +2
    • Falk Kühnel +1
  • Verified V +2
    • Dmitry Dulepov +2

Files 1

Review log 3

  1. Falk Kühnel commented on patch set 1 12/20/12, 08:59

    Looks good to me, but someone else must approve
  2. Dmitry Dulepov commented on patch set 1 V 0 12/20/12, 08:59

    by team member; Looks good to me, approved
  3. Dmitry Dulepov merged patch set 2 12/20/12, 08:59