Review main Merged

16992[BUGFIX] Fix rootline translation

Helmut Hummel CR +2 V +2 Hard +152 −112 updated 06/03/13, 20:49

Commit message

The fix in #42029 introduced a regression
as TSFE->tmpl->rootLine holds a reversed
rootline array, while in TSFE->rootLine
the order is "normal"

Additionally the call to getPageOverlay was wrong
because the result of the overlay was never used.

Lastly use the correct uid for looking up the
relation fields.

This change also cleans up the unit tests for
RootlineUtility and adds regression tests for
these issues.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Files 5