Review main Merged

17017[TASK] Remove function usage ctype_alnum in PageRenderer

Ingo Pfennigstorf CR +2 V +2 Easy +3 −3 updated 06/03/13, 20:49

Commit message

This fixes the problem that on some servers the PHP ctype extension
is not installed by default and results in a blank backend screen
when trying to edit a page.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Files 2

Review log 11

  1. Oliver Klee commented on patch set 1 01/28/13, 18:16

    Looks good to me, but someone else must approve
  2. Christian Kuhn commented on patch set 1 01/28/13, 18:16

    I would prefer that you didn't submit this we should at least check if some test can be created for this method ...
    6.1, 6.0
  3. Christian Kuhn commented on patch set 1 01/28/13, 18:16

    unit test?
  4. Christian Kuhn uploaded patch set 2 01/28/13, 18:16

  5. Christian Kuhn commented on patch set 2 01/28/13, 18:16

    Ah, cool. The method already has 2 tests for the namespace test that is changed here. New patch set just changes the 'Releases' line of the commit message to include 6.1 and adds two non php-namespaced test annotations along the way.
  6. Dan Kleine - geb. Untenzu commented on patch set 1 01/28/13, 18:16

    Looks good to me, but someone else must approve
  7. Dan Kleine - geb. Untenzu commented on patch set 1 01/28/13, 18:16

    Looks good to me, but someone else must approve
  8. Mr. Jenkins commented on patch set 1 01/28/13, 18:16

  9. Mr. Jenkins commented on patch set 2 01/28/13, 18:16

  10. Christian Kuhn commented on patch set 2 V 0 01/28/13, 18:16

    by team member; Looks good to me, approved merged as technical no-brainer, since it is also unit-test covered already.
  11. Christian Kuhn merged patch set 3 01/28/13, 18:16