Review main Merged

17283[BUGFIX] Include file tables in access list

Helmut Hummel CR +2 V +2 Normal +112 −3 updated 06/03/13, 20:49

Commit message

The BackendUtility::getExcludeFields method does not respect the
"ignoreRootLevelRestriction" configuration for these tables.
The result is that editors never see exclude fields as it is not
possible to set them in the access list in a backend group record.

Solution is to ignore the root level configuration if
"ignoreRootLevelRestriction" is also set in TCA.

This change also adds unit tests to check the fixed behavior
as well as the default behavior of this method.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Stefan Neufeind +1
    • Mattias Nilsson +1
  • Verified V +2
    • Helmut Hummel +2

Files 2

Review log 7

  1. Stefan Neufeind commented on patch set 2 01/05/13, 19:24

    Looks good to me, but someone else must approve seems to make sense reading commitmsg and code
  2. Helmut Hummel uploaded patch set 2 01/05/13, 19:24

  3. Mattias Nilsson commented on patch set 2 01/05/13, 19:24

    Looks good to me, but someone else must approve
  4. Mr. Jenkins commented on patch set 1 01/05/13, 19:24

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/7084/ : FAILURE
  5. Mr. Jenkins commented on patch set 2 01/05/13, 19:24

  6. Helmut Hummel commented on patch set 2 V 0 01/05/13, 19:24

    by team member; Looks good to me, approved
  7. Helmut Hummel merged patch set 3 01/05/13, 19:24