Review main Merged

17302[BUGFIX] phpdoc: $urlParameters can be a string

Stefan Neufeind CR +2 V +2 Easy +4 −4 updated 06/03/13, 20:49

Commit message

In functions like getTypoLink() $urlParameters can also
be a string. A string is expected to be URL-encoded already,
as an array the keys are expected to be URL-encoded already
but the values not. Clearly point that out in the phpdocs.

Review

  • Code review CR +2
    • Jigal van Hemert +2
  • Verified V +2
    • Jigal van Hemert +2

Files 1

Review log 3

  1. Mr. Jenkins commented on patch set 1 01/01/13, 11:06

  2. Jigal van Hemert commented on patch set 1 V 0 01/01/13, 11:06

    by team member; Looks good to me, approved No code changes. Description is more accurate now.
  3. Jigal van Hemert merged patch set 2 01/01/13, 11:06