Review main Abandoned

17331[BUGFIX] Fix email validation due to wrong use of IDNA

Thomas Off CR 0 V 0 Easy +2 −1 updated 01/05/15, 09:06

Commit message

The IDNA converter is used to prepare for international domain names;
but as the conversion is applied to the whole email address, umlauts
in the local part of an email address also get converted and the email
address subsequently is regarded as valid though umlauts are not allowed
in the local part according to RFC 5321 where only normal ASCII
characters (plus some special characters) are allowed
(see http://tools.ietf.org/html/rfc5322#section-3.2.3).

To fix the bug, the email address has to be split and only the domain
part must be converted using IDNA; the email address is then composed
again and validated.

EDIT: Fix violation of TYPO3 coding guidelines.

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1