Review TYPO3_6-0 Merged

17354[BUGFIX] Invalid call to t3lib_TCEmain::processRemapStack()

Oliver Hader CR +2 V +2 Easy +0 −2 updated 06/03/13, 20:49

Commit message

The remap stack in t3lib_TCEmain/DataHandler is dedicated to
process pending records and references after all database
operations. This occurs if child-parent-structures are handled
and not all data has been persisted yet.

However, there's one call that at least influences this
behaviour on workspaces using IRRE records, which should happen
at the end of processing data-map or command-map - here's the
call-stack:
* copyRecord_raw($table, $uid, $pid, $overrideArray, ...)
* insertNewCopyVersion($table, $fieldArray, $realPid)
* processRemapStack()

This behaviour has been introduced in 2007 with commit
ecff9833c02e6bc61d98a6ff4b34b741c5d732ad for a first draft to
get IRRE working in workspaces, which was then partly reverted
during TYPO3 4.2 development - but some changes obviously have
been overseen.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Files 1