17367[BUGFIX] File list: Deleted files are shown
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 1
Review log 10
-
Stefan Neufeind commented on patch set 2 04/07/13, 09:16
@Helmut: As far as I understand "deleted" is a commonly used and usually present field in the DB. So if it's set to deleted, shouldn't it be honoured like we usually do?FileList.php:274check for isIndexed() needed here? -
Stefan Neufeind commented on patch set 2 04/07/13, 09:16
(1 inline comment) -
Helmut Hummel commented on patch set 2 04/07/13, 09:16
Do not submit As far as I understand, nothing needs to be changed here, but the change in https://review.typo3.org/16403 needs to be properly implemented. Please fix the implementation there and abandon this change. -
Steffen Ritter commented on patch set 2 04/07/13, 09:16
Do not submit File list module shows files not records! This is not dam... -
Christian Weiske uploaded patch set 2 04/07/13, 09:16
FileList.php:274ReplyYes. The "deleted" property gets loaded through calling it; it is not available before. -
Christian Weiske commented on patch set 2 04/07/13, 09:16
(1 inline comment) -
Christian Weiske commented on patch set 2 04/07/13, 09:16
Shall the "deleted" property of the database entry be taken into account at all? For example by striking it through as Philipp Gampe suggested? -
Mr. Jenkins commented on patch set 1 04/07/13, 09:16
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/7103/ : FAILURE -
Mr. Jenkins commented on patch set 2 04/07/13, 09:16
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7104/ : SUCCESS -
Benni Mack commented on patch set 2 04/07/13, 09:16
Abandoned see messages. is already solved in another way.