Review main Merged

17413[BUGFIX] LocalDriver needs to respect "is_writeable"

Georg Ringer CR +2 V +2 Easy +3 −3 updated 06/03/13, 20:49

Commit message

The LocalDriver needs also to respect the flag "is_writeable".
This means: if the flag is not set, no folder/file can be edited/moved...

Review

  • Code review CR +2
    • Helmut Hummel +2
  • Verified V +2
    • Helmut Hummel +2

Files 1

Review log 19

  1. Georg Ringer uploaded patch set 2 01/12/13, 15:29

  2. Georg Ringer uploaded patch set 3 01/12/13, 15:29

  3. Georg Ringer uploaded patch set 4 01/12/13, 15:29

  4. Georg Ringer uploaded patch set 5 01/12/13, 15:29

  5. Georg Ringer uploaded patch set 6 01/12/13, 15:29

  6. Georg Ringer uploaded patch set 7 01/12/13, 15:29

  7. Georg Ringer uploaded patch set 8 01/12/13, 15:29

  8. Mattias Nilsson commented on patch set 4 01/12/13, 15:29

    Looks good to me, but someone else must approve
  9. Mattias Nilsson commented on patch set 4 01/12/13, 15:29

    I would prefer that you didn't submit this
  10. Mr. Jenkins commented on patch set 1 01/12/13, 15:29

  11. Mr. Jenkins commented on patch set 2 01/12/13, 15:29

  12. Mr. Jenkins commented on patch set 3 01/12/13, 15:29

  13. Mr. Jenkins commented on patch set 4 01/12/13, 15:29

  14. Mr. Jenkins commented on patch set 5 01/12/13, 15:29

  15. Mr. Jenkins commented on patch set 6 01/12/13, 15:29

  16. Mr. Jenkins commented on patch set 7 01/12/13, 15:29

  17. Mr. Jenkins commented on patch set 8 01/12/13, 15:29

  18. Helmut Hummel merged patch set 9 01/12/13, 15:29

  19. Helmut Hummel commented on patch set 9 01/12/13, 18:26

    Reverted This patchset was reverted in change: I6638ca1c82482bd1b9477fb343b7d566e8fe559c