Review main Merged

17501[BUGFIX] LocalDriver needs to respect "is_writeable"

Helmut Hummel CR +2 V +2 Easy +3 −3 updated 06/03/13, 20:49

Commit message

The LocalDriver needs also to respect the flag "is_writeable".
This means: if the flag is not set, no folder/file can be edited/moved...

Review

  • Code review CR +2
    • Helmut Hummel +2
  • Verified V +2
    • Helmut Hummel +2

Files 2

Review log 10

  1. Helmut Hummel commented on patch set 1 02/16/13, 18:00

    Fails; I would prefer that you didn't submit this I repushed the change (https://review.typo3.org/17413) that has been reverted because of failing tests.
  2. Helmut Hummel uploaded patch set 2 02/16/13, 18:00

  3. Helmut Hummel uploaded patch set 3 02/16/13, 18:00

  4. Helmut Hummel uploaded patch set 4 02/16/13, 18:00

  5. Mr. Jenkins commented on patch set 1 02/16/13, 18:00

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/7151/ : FAILURE
  6. Mr. Jenkins commented on patch set 2 02/16/13, 18:00

  7. Mr. Jenkins commented on patch set 3 02/16/13, 18:00

  8. Mr. Jenkins commented on patch set 4 02/16/13, 18:00

  9. Helmut Hummel commented on patch set 4 V 0 02/16/13, 18:00

    by team member; Looks good to me, approved
  10. Helmut Hummel merged patch set 5 02/16/13, 18:00