Review main Merged

17504[BUGFIX] Don't set empty from-name when sending email

Stefan Neufeind CR +2 V +2 Easy +5 −1 updated 06/03/13, 20:49

Commit message

If no name is specified, only an email-address, for a sender
avoid setting an empty "from"-parameter.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Georg Ringer +1
  • Verified V +2
    • Christian Kuhn +2
    • Georg Ringer +1

Files 1

Review log 14

  1. Stefan Neufeind commented on patch set 1 04/12/13, 20:57

    ping
  2. Stefan Neufeind commented on patch set 1 04/12/13, 20:57

    (1 inline comment)
  3. Stefan Neufeind commented on patch set 1 04/12/13, 20:57

    (1 inline comment) somebody please have a look
  4. Markus Klein commented on patch set 1 04/12/13, 20:57

    (1 inline comment)

    MailPostProcessor.php:131

    Maybe it would even suffice to set this to NULL by default.

    MailPostProcessor.php:131 Reply

    Ah yeah, right of course.
  5. Markus Klein commented on patch set 1 04/12/13, 20:57

    Verified; Looks good to me, but someone else must approve No-brainer!
  6. Markus Klein commented on patch set 1 04/12/13, 20:57

    (1 inline comment)
  7. Georg Ringer uploaded patch set 2 04/12/13, 20:57

  8. Georg Ringer commented on patch set 2 04/12/13, 20:57

    Verified; Looks good to me, but someone else must approve
  9. Philipp Gampe commented on patch set 1 04/12/13, 20:57

    Looks good to me, but someone else must approve IMHO needs a Unit Test.
  10. Mr. Jenkins commented on patch set 1 04/12/13, 20:57

  11. Mr. Jenkins commented on patch set 2 04/12/13, 20:57

  12. Wouter Wolters commented on patch set 1 04/12/13, 20:57

    Looks good to me, but someone else must approve
  13. Christian Kuhn commented on patch set 2 V 0 04/12/13, 20:57

    by team member; Looks good to me, approved
  14. Christian Kuhn merged patch set 3 04/12/13, 20:57