17504[BUGFIX] Don't set empty from-name when sending email
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Georg Ringer +1
-
Verified V +2
- Christian Kuhn +2
- Georg Ringer +1
Files 1
Review log 14
-
Stefan Neufeind commented on patch set 1 04/12/13, 20:57
ping -
Stefan Neufeind commented on patch set 1 04/12/13, 20:57
(1 inline comment) -
Stefan Neufeind commented on patch set 1 04/12/13, 20:57
(1 inline comment) somebody please have a look -
Markus Klein commented on patch set 1 04/12/13, 20:57
(1 inline comment)MailPostProcessor.php:131Maybe it would even suffice to set this to NULL by default.MailPostProcessor.php:131ReplyAh yeah, right of course. -
Markus Klein commented on patch set 1 04/12/13, 20:57
Verified; Looks good to me, but someone else must approve No-brainer! -
Markus Klein commented on patch set 1 04/12/13, 20:57
(1 inline comment) -
Georg Ringer uploaded patch set 2 04/12/13, 20:57
-
Georg Ringer commented on patch set 2 04/12/13, 20:57
Verified; Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 1 04/12/13, 20:57
Looks good to me, but someone else must approve IMHO needs a Unit Test. -
Mr. Jenkins commented on patch set 1 04/12/13, 20:57
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7153/ : SUCCESS -
Mr. Jenkins commented on patch set 2 04/12/13, 20:57
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8372/ : SUCCESS -
Wouter Wolters commented on patch set 1 04/12/13, 20:57
Looks good to me, but someone else must approve -
Christian Kuhn commented on patch set 2 V 0 04/12/13, 20:57
by team member; Looks good to me, approved -
Christian Kuhn merged patch set 3 04/12/13, 20:57