Review TYPO3_6-0 Merged

17720[BUGFIX] Fix problem with saving extension configuration in different tabs

Christian Kuhn CR +2 V +2 Normal +103 −5 updated 06/03/13, 20:49

Commit message

The new ConfigurationUtility is working internally with configuration as
valued array, but the existing configuration is serialized in the old
nested format. When merging these two, exising configuration was not
merged correctly, resulting in error where configuration set in other tabs
was lost when saving.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Files 2

Review log 2

  1. Christian Kuhn commented on patch set 1 V 0 01/25/13, 19:56

    by team member; Looks good to me, approved Direct cherry-pick from 6.1 version, merged. The patch does not completly solve the issue, since *changes* on one tab are still not saved if hitting submit button on a different tab. But that could be solved in another patch, at least for now, existing differences from default settings from a different tab are not lost if hitting submit in a specific tab already, so the data merging works.
  2. Christian Kuhn merged patch set 2 01/25/13, 19:56