Classes ConfigurationUtility and ConfigurationItemRepository handle
the extension managers extension configuration settings.
Configuration sources are ext_conf_template.txt files,
LocalConfiguration.php and the extension manager configuration
forms. They all have different formats and structures, thus
the code to merge all that is not exactly easy.
This patch shifts some code around in order to make the current
handling better understandable for easier debugging. The API is
still not as simple as it should be, but for now some
code smell is solved:
* Use @inject annotation for dependency injection to reduce
number of code lines.
* Remove dependency injected objects if possible and rely on
injection of objectManager only if the object is not widely
used in the class.
* Disentangle a method call chain from InstallUtility to
ConfigurationUtility back to InstallUtility by removing method
writeExtensionTypoScriptStyleConfigurationToLocalconf() from
InstallUtility and merging functionality with
ConfigurationUtility->writeConfiguration().
* Remove public method createArrayFromConstants() from
ConfigurationItemRepository and move to ConfigurationUtility
under new name
getDefaultConfigurationFromExtConfTemplateAsFlatItemArray().
* Rename ConfigurationItemRepository->findByExtension() to
findByExtensionKey() and always let it return an
ObjectStorage, even if empty.
* Simplify several method signatures, mostly of protected methods
to one parameter only, moving only the extension key around.
* Better encapsulating of low level code in protected methods
instead of duplicated low level code in in entry methods
or controller logic.
* Resolve code smell in unit tests with better mocking and
structured tests.