17811[BUGFIX] LocalConfiguration extListArray should be written without keys
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Wouter Wolters +1
- Mattias Nilsson +1
-
Verified V +2
- Christian Kuhn +2
- Wouter Wolters +1
Files 3
Review log 18
-
Jan-Erik Revsbech commented on patch set 1 01/30/13, 18:55
(9 inline comments) Will post a new patch set with the changes -
Jan-Erik Revsbech uploaded patch set 2 01/30/13, 18:55
-
Jan-Erik Revsbech commented on patch set 2 01/30/13, 18:55
Verified; Looks good to me, but someone else must approve -
Jan-Erik Revsbech commented on patch set 2 01/30/13, 18:55
(1 inline comment) I'll change the int to integer, and add a topic -
Jan-Erik Revsbech uploaded patch set 3 01/30/13, 18:55
-
Christian Kuhn commented on patch set 1 01/30/13, 18:55
(8 inline comments) very nice! thx! i just added some small remarks, mostly to improve documentation. -
Christian Kuhn commented on patch set 2 01/30/13, 18:55
@wouter: i started to be not nitpicking about the topic branch. if the change-id is not changed during back porting, this is a much better indicator than the manually set topic: the topic needs manual gerrit search string modifications to see what is the current state in which branch, the Change-Id search link lists all without modification. thus i usually do not set the topic anymore, but instead take care that the change-id line is always the same in all branches. -
Christian Kuhn commented on patch set 2 01/30/13, 18:55
for the patch: looks very good already. i'll give it a shot tomorrow. -
Christian Kuhn commented on patch set 3 1 comment 01/30/13, 18:55
Verified; Looks good to me, but someone else must approve Tested: Works fine :) Patch is great, very clean. Imho ready to go. -
Mattias Nilsson commented on patch set 3 01/30/13, 18:55
Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 01/30/13, 18:55
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7249/ : SUCCESS -
Mr. Jenkins commented on patch set 2 01/30/13, 18:55
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7250/ : SUCCESS -
Mr. Jenkins commented on patch set 3 01/30/13, 18:55
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7252/ : SUCCESS -
Wouter Wolters commented on patch set 1 01/30/13, 18:55
(1 inline comment)ArrayUtility.php:414again a small nitpick: integer here:)ArrayUtility.php:425@param integer Missing @return here -
Wouter Wolters commented on patch set 2 01/30/13, 18:55
(1 inline comment) One leftover. And the patch is missing a topic. You can add the topic to do the following command while pushing. git push origin HEAD:refs/for/master/44938 -
Wouter Wolters commented on patch set 3 01/30/13, 18:55
Verified; Looks good to me, but someone else must approve -
Christian Kuhn commented on patch set 3 V 0 01/30/13, 18:55
by team member; Looks good to me, approved -
Christian Kuhn merged patch set 4 01/30/13, 18:55