Review main Merged

17980[BUGFIX] tools_dbint needs to be called via mod.php

Philipp Gampe CR +2 V +2 Easy +10 −5 updated 06/03/13, 20:49

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Files 3

Review log 4

  1. Philipp Gampe commented on patch set 1 02/03/13, 17:24

    (1 inline comment)

    ActionTask.php:718

    ugly line ... I just did an auto format with PhpStorm.
  2. Mr. Jenkins commented on patch set 1 02/03/13, 17:24

  3. Christian Kuhn commented on patch set 1 V 0 02/03/13, 17:24

    by team member; Looks good to me, approved +1 I've tested all three links (from about modules to dbint, from reports module to dbint and from task center to dbint). They are ok now. Since I want don't want to enforce anyone else to setup the according use cases and i'm sure it is now better than before with this patch, it is merged now.
  4. Christian Kuhn merged patch set 2 02/03/13, 17:24