Review main Merged

18081[FEATURE] Add a "Run task" button to task overview

Thomas Löffler CR +2 V +2 Easy +35 −7 updated 06/03/13, 20:49

Commit message

Run a task directly with one click in task list

Review

  • Code review CR +2
    • Ingo Renner +2
  • Verified V +2
    • Ingo Renner +2

Issues 1

Files 5

Review log 11

  1. Ingo Renner commented on patch set 1 02/16/13, 23:07

    I would prefer that you didn't submit this can't use the paging action icon
  2. Ingo Renner commented on patch set 1 02/16/13, 23:07

    it's just that the semantics are wrong. You're using an icon that's meant to be used for pagination. If that is changed, it'll change here, too. I would propose to use that icon colored green. It at least needs to be a new/separate name. I'll provide an icon later.
  3. Ingo Renner commented on patch set 2 V 0 02/16/13, 23:07

    by team member; Looks good to me, approved Added a custom icon and made clicking the icon trigger the status icon, too.
  4. Ingo Renner uploaded patch set 2 02/16/13, 23:07

  5. Stefan Neufeind commented on patch set 1 02/16/13, 23:07

    Would be great to get this button done. There is a proposed icon on the forge-issue for this. Imho turning the interface to an extbase-based list should be a separate issue/feature-request. I agree it would be great to have. But I don't see why "the idea" should block something as small as this icon.
  6. Christian Kuhn commented on patch set 1 02/16/13, 23:07

    Not tested, not reviewed, but an idea for a follow-up: It shouldn't be too hard to transfer the 'list' section of the controller logic to some extbase view, maybe even using standaloneview without full extbase and linking the rest to existing things. That would make changes in this area a lot easier to review.
  7. Thomas Löffler commented on patch set 1 02/16/13, 23:07

    New Icon or other existing icon?
  8. Mr. Jenkins commented on patch set 1 02/16/13, 23:07

  9. Mr. Jenkins commented on patch set 2 02/16/13, 23:07

  10. Wouter Wolters commented on patch set 1 V 0 02/16/13, 23:07

    I'm with Ingo here. The icon does not fit there. Tested it and that works fine:)
  11. Ingo Renner merged patch set 3 02/16/13, 23:07