Review main Merged

18106[BUGFIX] Exception when scheduling "at" execution time

Philipp Gampe CR +2 V +2 Easy +10 −4 updated 06/03/13, 20:49

Commit message

If a recurring task is converted to a single task and the endtime is set
before now, then the exception "Task is past end date" is thrown as the
next execution time for the "at" daemon is calculated.

The fix is to catch the exceptions and ignore them, as we don't care
about tasks that will never run again when calculating the next
execution date.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Philipp Gampe +1
  • Verified V +2
    • Christian Kuhn +2
    • Philipp Gampe +1

Files 2

Review log 14

  1. Andreas Wolf commented on patch set 1 02/10/13, 00:29

    Fails I could not reproduce the problem you describe.
  2. Andreas Wolf commented on patch set 1 02/10/13, 00:29

    No score Ok, can reproduce it now, but the patch does not fix it on my installation. Will provide an updated patch soon.
  3. Andreas Wolf uploaded patch set 2 02/10/13, 00:29

  4. Andreas Wolf uploaded patch set 3 02/10/13, 00:29

  5. Christian Kuhn commented on patch set 3 02/10/13, 00:29

    Verified; Looks good to me, but someone else must approve
  6. Christian Kuhn commented on patch set 3 V 0 02/10/13, 00:29

    by team member; Looks good to me, approved
  7. Philipp Gampe commented on patch set 1 02/10/13, 00:29

    You need to enable the use of the at daemon in the scheduler extension settings and you need the at daemon on your test system.
  8. Philipp Gampe commented on patch set 2 02/10/13, 00:29

    I would prefer that you didn't submit this description does not match
  9. Philipp Gampe commented on patch set 2 02/10/13, 00:29

    Verified; Looks good to me, but someone else must approve
  10. Philipp Gampe commented on patch set 3 02/10/13, 00:29

    Verified; Looks good to me, but someone else must approve
  11. Mr. Jenkins commented on patch set 1 02/10/13, 00:29

  12. Mr. Jenkins commented on patch set 2 02/10/13, 00:29

  13. Mr. Jenkins commented on patch set 3 02/10/13, 00:29

  14. Christian Kuhn merged patch set 4 02/10/13, 00:29