Review main Merged

18191[BUGFIX] Exception when deleted file is in clipboard

Andreas Wolf CR +2 V +2 Easy +8 −1 updated 06/03/13, 20:49

Commit message

When a file is deleted while it is part of a clipboard, an exception is
thrown when the clipboard is reconstituted. This exception has to be
catched, otherwise the file module will be unusable.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Thomas Scheibitz +1
  • Verified V +2
    • Christian Kuhn +2
    • Thomas Scheibitz +1

Issues 1

Files 1

Review log 6

  1. Thomas Scheibitz commented on patch set 1 03/13/13, 19:10

    Verified; Looks good to me, but someone else must approve
  2. Philipp Gampe commented on patch set 1 03/13/13, 19:10

    (1 inline comment)

    Clipboard.php:753

    Isn't there a more specific FAL exception that only catches FAL exceptions?
  3. Mr. Jenkins commented on patch set 1 03/13/13, 19:10

  4. Wouter Wolters commented on patch set 1 03/13/13, 19:10

    Looks good to me, but someone else must approve

    Clipboard.php:753 Reply

    This is the only \RuntimeException thrown in the resourcefactory.. So I guess this is the only valid one here.
  5. Christian Kuhn commented on patch set 1 V 0 03/13/13, 19:10

    by team member; Looks good to me, approved
  6. Christian Kuhn merged patch set 2 03/13/13, 19:10