18222[BUGFIX] Do not overwrite imagecaption in content adapter
Commit message
Review
-
Code review CR +2
- Helmut Hummel +2
- Wouter Wolters +1
-
Verified V +2
- Helmut Hummel +2
- Wouter Wolters +1
Files 2
Review log 13
-
Helmut Hummel uploaded patch set 2 03/05/13, 13:34
-
Stefan Neufeind commented on patch set 3 03/05/13, 13:34
Looks good to me, but someone else must approve Reading explanation and source this seems to make sense to me.FrontendContentAdapterServiceTest.php:160whitespace according to gerrit -
Helmut Hummel uploaded patch set 3 03/05/13, 13:34
-
Steffen Ritter commented on patch set 3 03/05/13, 13:34
Looks good to me, approved Makes sense.... -
Mr. Jenkins commented on patch set 1 03/05/13, 13:34
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/7471/ : FAILURE -
Mr. Jenkins commented on patch set 2 03/05/13, 13:34
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7472/ : SUCCESS -
Mr. Jenkins commented on patch set 3 03/05/13, 13:34
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7478/ : SUCCESS -
Wouter Wolters commented on patch set 3 03/05/13, 13:34
I would prefer that you didn't submit this Will update in a minuteFrontendContentAdapterService.php:132This order here is not correct. -
Mr. Jenkins commented on patch set 4 03/05/13, 13:34
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7573/ : SUCCESS -
Wouter Wolters commented on patch set 4 03/05/13, 13:34
Verified; Looks good to me, but someone else must approve -
Wouter Wolters uploaded patch set 4 03/05/13, 13:34
-
Helmut Hummel commented on patch set 4 V 0 03/05/13, 13:34
by team member; Looks good to me, approved -
Helmut Hummel merged patch set 5 03/05/13, 13:34