Review main Merged

18222[BUGFIX] Do not overwrite imagecaption in content adapter

Helmut Hummel CR +2 V +2 Normal +99 −9 updated 06/03/13, 20:49

Commit message

Problem:
Create a new content element of type file links,
add a file relation and a description to this file.
Switch this element to be an image element,
add an image and a description of the image

Expected result:
An image with the image description is shown

Actual result:
An image with the description of the file is shown.

Solution:
Check if the field actually is shown in the selected
content element type.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Wouter Wolters +1
  • Verified V +2
    • Helmut Hummel +2
    • Wouter Wolters +1

Files 2

Review log 13

  1. Helmut Hummel uploaded patch set 2 03/05/13, 13:34

  2. Stefan Neufeind commented on patch set 3 03/05/13, 13:34

    Looks good to me, but someone else must approve Reading explanation and source this seems to make sense to me.

    FrontendContentAdapterServiceTest.php:160

    whitespace according to gerrit
  3. Helmut Hummel uploaded patch set 3 03/05/13, 13:34

  4. Steffen Ritter commented on patch set 3 03/05/13, 13:34

    Looks good to me, approved Makes sense....
  5. Mr. Jenkins commented on patch set 1 03/05/13, 13:34

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/7471/ : FAILURE
  6. Mr. Jenkins commented on patch set 2 03/05/13, 13:34

  7. Mr. Jenkins commented on patch set 3 03/05/13, 13:34

  8. Wouter Wolters commented on patch set 3 03/05/13, 13:34

    I would prefer that you didn't submit this Will update in a minute

    FrontendContentAdapterService.php:132

    This order here is not correct.
  9. Mr. Jenkins commented on patch set 4 03/05/13, 13:34

  10. Wouter Wolters commented on patch set 4 03/05/13, 13:34

    Verified; Looks good to me, but someone else must approve
  11. Wouter Wolters uploaded patch set 4 03/05/13, 13:34

  12. Helmut Hummel commented on patch set 4 V 0 03/05/13, 13:34

    by team member; Looks good to me, approved
  13. Helmut Hummel merged patch set 5 03/05/13, 13:34