Review main Abandoned

18259[BUGFIX] tslib_content_Media does not clean up $conf['file.']

Michiel Roos CR 0 V 0 Easy +1 −0 updated 06/03/13, 20:49

Commit message

When a url is passed to a MEDIA object, a proper
url is extracted. This will make sure a youtube
url is correctly rewritten. The result of the
cleaning action is written to $conf['file'].

When an url is passend in through $conf['file.']
and the url is cleaned, the result is written to
$conf['file'] but the original $conf['file.'] is
left untouched.

When the conf object is passed onto SWFOBJECT
for final rendering, the first property that is
checked is the dirty $conf['file.'] and not the
clean $conf['file'].

Currently this prevents proper rendering of a
video when using a 'file.' object to render a
video url.

The solution is to unset $conf['file.'] after
$conf['file'] has been set.

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 3

  1. Mr. Jenkins commented on patch set 1 02/14/13, 11:56

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/7496/ : FAILURE
  2. Wouter Wolters commented on patch set 1 02/14/13, 11:56

    I would prefer that you didn't submit this He Michiel, Is this only for the 4.5 branch? If so then this changed needs to be pushed into the TYPO3_4-5 branch and not master.
  3. Michiel Roos commented on patch set 1 02/14/13, 11:56

    Abandoned Pushed to wrong branch