Review TYPO3_4-5 Abandoned

18260[BUGFIX] tslib_content_Media does not clean up $conf['file.']

Michiel Roos CR 0 V 0 Easy +1 −0 updated 05/09/15, 15:46

Commit message

When a url is passed to a MEDIA object, a proper
url is extracted. This will make sure a youtube
url is correctly rewritten. The result of the
cleaning action is written to $conf['file'].

When an url is passend in through $conf['file.']
and the url is cleaned, the result is written to
$conf['file'] but the original $conf['file.'] is
left untouched.

When the conf object is passed onto SWFOBJECT
for final rendering, the first property that is
checked is the dirty $conf['file.'] and not the
clean $conf['file'].

Currently this prevents proper rendering of a
video when using a 'file.' object to render a
video url.

The solution is to unset $conf['file.'] after
$conf['file'] has been set.

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Files 1