18301[TASK] Declare non static methods as static
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Oliver Klee +1
- Wouter Wolters +1
- Dmitry Dulepov +1
- Soren Malling +1
- Simon Schaufelberger +1
-
Verified V +2
- Christian Kuhn +2
- Wouter Wolters +1
- Soren Malling +1
- Simon Schaufelberger +1
Issues 1
Files 1
Review log 22
-
Dmitry Dulepov uploaded patch set 2 03/18/13, 20:31
-
Dmitry Dulepov commented on patch set 2 03/18/13, 20:31
Looks good to me, but someone else must approve Just fixed static/dynamic usage in the other place. Since this changes method signature, it should not go to previous releases. -
Dmitry Dulepov uploaded patch set 3 03/18/13, 20:31
-
Dmitry Dulepov commented on patch set 3 03/18/13, 20:31
Explanation makes sense. If the method does not require instance variables, it makes sense to make it static. -
Dmitry Dulepov commented on patch set 3 03/18/13, 20:31
Looks good to me, but someone else must approve Just fixed static/dynamic usage in the other place. Since this changes method signature, it should not go to previous releases. -
Dmitry Dulepov commented on patch set 3 03/18/13, 20:31
(1 inline comment) -
Markus Klein commented on patch set 1 03/18/13, 20:31
Fails; I would prefer that you didn't submit this The method is called in static context in PageLayoutView but also in non-static BackendLayoutView. This is IMO a bugfix and not a TASK and should also be backported.BackendLayoutView.php:161What's the reason for having this information twice? Isn't the static keyword below enough? -
Markus Klein commented on patch set 3 03/18/13, 20:31
Simply because it is already used in a static context in another file. It seems much cleaner to me, to retrieve the default column setting via a static method than having the overhead of instantiating the class beforehand. -
Markus Klein commented on patch set 3 03/18/13, 20:31
(1 inline comment) -
Oliver Klee commented on patch set 1 03/18/13, 20:31
Looks good to me, but someone else must approve -
Oliver Klee commented on patch set 3 03/18/13, 20:31
Looks good to me, but someone else must approve -
Susi Moog commented on patch set 1 03/18/13, 20:31
Looks good to me, but someone else must approve -
Christian Kuhn commented on patch set 3 V 0 03/18/13, 20:31
by team member; Looks good to me, approved Ok, I was not aware this method is already called statically at a different position. Fine with me. Merged. -
Christian Kuhn commented on patch set 3 03/18/13, 20:31
I would prefer that you didn't submit this I don't understand why we should declare getDefaultColumnLayout static. It *could* be static, but the whole class is not static itself, so there is imho no direct reason to make this specific method static, just because we can. -
Soren Malling commented on patch set 3 03/18/13, 20:31
Verified; Looks good to me, but someone else must approve -
Thomas Löffler commented on patch set 1 03/18/13, 20:31
Looks good to me, but someone else must approve -
Simon Schaufelberger commented on patch set 3 03/18/13, 20:31
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 03/18/13, 20:31
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7505/ : SUCCESS -
Mr. Jenkins commented on patch set 2 03/18/13, 20:31
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7539/ : SUCCESS -
Mr. Jenkins commented on patch set 3 03/18/13, 20:31
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7541/ : SUCCESS -
Wouter Wolters commented on patch set 3 03/18/13, 20:31
Verified; Looks good to me, but someone else must approve -
Christian Kuhn merged patch set 4 03/18/13, 20:31