18362[TASK] Don't render table header if no files given
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Wouter Wolters +1
- Felix Kopp +1
- Soren Malling +1
-
Verified V +2
- Christian Kuhn +2
- Wouter Wolters +1
- Felix Kopp +1
- Soren Malling +1
Issues 1
Files 1
Review log 9
-
Soren Malling commented on patch set 1 03/08/13, 10:01
Verified; Looks good to me, but someone else must approve It works as expected, but maybe a notice of somekind would help the user experience. flashmessage with the "notice" class saying, "No files in this folder"? -
Soren Malling commented on patch set 1 03/08/13, 10:01
Similar to this message, when a storage isn't available https://www.evernote.com/shard/s58/sh/f3e803d4-4a75-4eb9-b12e-58dada3eda66/b3f3bf78d713ad2438ea4efe76509c1d -
Felix Kopp commented on patch set 1 03/08/13, 10:01
Verified; Looks good to me, but someone else must approve -
Felix Kopp commented on patch set 1 03/08/13, 10:01
I guess no message is needed since OS finder+explorer also do not display notices in empty folders. We should display the folder's title. I will bring another patch-set. -
Mattias Nilsson commented on patch set 1 03/08/13, 10:01
(1 inline comment)Why not also add this to 6.0? -
Mr. Jenkins commented on patch set 1 03/08/13, 10:01
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7534/ : SUCCESS -
Wouter Wolters commented on patch set 1 03/08/13, 10:01
Verified; Looks good to me, but someone else must approve -
Christian Kuhn commented on patch set 1 V 0 03/08/13, 10:01
by team member; Looks good to me, approved -
Christian Kuhn merged patch set 2 03/08/13, 10:01