Review main Merged

18362[TASK] Don't render table header if no files given

Georg Ringer CR +2 V +2 Easy +7 −6 updated 06/03/13, 20:49

Commit message

It doesn't make sense to render the table header in
the filelist module if no files are given.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Felix Kopp +1
    • Soren Malling +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Felix Kopp +1
    • Soren Malling +1

Issues 1

Files 1

Review log 9

  1. Soren Malling commented on patch set 1 03/08/13, 10:01

    Verified; Looks good to me, but someone else must approve It works as expected, but maybe a notice of somekind would help the user experience. flashmessage with the "notice" class saying, "No files in this folder"?
  2. Soren Malling commented on patch set 1 03/08/13, 10:01

  3. Felix Kopp commented on patch set 1 03/08/13, 10:01

    Verified; Looks good to me, but someone else must approve
  4. Felix Kopp commented on patch set 1 03/08/13, 10:01

    I guess no message is needed since OS finder+explorer also do not display notices in empty folders. We should display the folder's title. I will bring another patch-set.
  5. Mattias Nilsson commented on patch set 1 03/08/13, 10:01

    (1 inline comment)
    Why not also add this to 6.0?
  6. Mr. Jenkins commented on patch set 1 03/08/13, 10:01

  7. Wouter Wolters commented on patch set 1 03/08/13, 10:01

    Verified; Looks good to me, but someone else must approve
  8. Christian Kuhn commented on patch set 1 V 0 03/08/13, 10:01

    by team member; Looks good to me, approved
  9. Christian Kuhn merged patch set 2 03/08/13, 10:01