18826[BUGFIX] Handle symlink on extension update
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
-
Verified V +2
- Christian Kuhn +2
Issues 1
Files 2
Review log 9
-
Christian Kuhn uploaded patch set 2 03/11/13, 19:41
-
Christian Kuhn commented on patch set 2 03/11/13, 19:41
Verified; Looks good to me, but someone else must approve @Phillip: I've changed multiple things in patch set 2: * The patch itself was faulty and didn't work (unlink only works properly without trailing slash) * Separated the tests to two different tests, in order to apply to 'one assertion per test only' rule. -
Christian Kuhn uploaded patch set 3 03/11/13, 19:41
-
Philipp Gampe commented on patch set 1 03/11/13, 19:41
BUG or FEATURE? -
Anja Leichsenring commented on patch set 2 03/11/13, 19:41
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 03/11/13, 19:41
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7671/ : SUCCESS -
Mr. Jenkins commented on patch set 2 03/11/13, 19:41
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7677/ : SUCCESS -
Christian Kuhn commented on patch set 3 V 0 03/11/13, 19:41
by team member; Looks good to me, approved Minor test adaption: test files are created in typo3temp, but not in typo3conf/ext anymore. Will merge now. -
Christian Kuhn merged patch set 4 03/11/13, 19:41