18978[BUGFIX] Fix PHP warning in BackendUtility::lockRecords
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Markus Klein +1
-
Verified V +2
- Christian Kuhn +2
Files 1
Review log 17
-
Stefan Neufeind commented on patch set 2 1 comment 03/17/13, 21:20
Looks good to me, but someone else must approve I agree we should reduce the number of checkes (see inline). But in general fine with me. -
Markus Klein commented on patch set 2 03/17/13, 21:20
Looks good to me, but someone else must approveBackendUtility.php:2940Just one more nitpick. Since this is now a pretty simple check, I'd suggest to negate the condition and make it a guard clause with a simple return statement.BackendUtility.php:2945Do we really need that many checks here? Wouldn't it suffice to do the first two checks? -
Helmut Hummel uploaded patch set 2 03/17/13, 21:20
-
Helmut Hummel uploaded patch set 3 03/17/13, 21:20
-
Helmut Hummel commented on patch set 3 03/17/13, 21:20
Thanks for the feedback. isset($GLOBALS['BE_USER']->user['uid'])) indeed handles both cases (BE_USER not set and user['uid'] not set) correctly and does neither throw warnings nor notices -
Markus Klein commented on patch set 4 1 comment 03/17/13, 21:20
Looks good to me, but someone else must approve -
Helmut Hummel uploaded patch set 4 03/17/13, 21:20
-
Helmut Hummel commented on patch set 4 03/17/13, 21:20
updated commit message to include this into older releases (LTS in particular) since it has been reported as a problem also in these versions -
Christian Kuhn commented on patch set 2 03/17/13, 21:20
Looks good to me, but someone else must approve will test soon.BackendUtility.php:2940Replyimho not really needed. -
Christian Kuhn commented on patch set 4 03/17/13, 21:20
(1 inline comment) -
Mattias Nilsson commented on patch set 2 03/17/13, 21:20
Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 03/17/13, 21:20
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7769/ : SUCCESS -
Mr. Jenkins commented on patch set 2 03/17/13, 21:20
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7770/ : SUCCESS -
Mr. Jenkins commented on patch set 3 03/17/13, 21:20
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7777/ : SUCCESS -
Mr. Jenkins commented on patch set 4 03/17/13, 21:20
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7778/ : SUCCESS -
Christian Kuhn commented on patch set 4 V 0 03/17/13, 21:20
by team member; Looks good to me, approved -
Christian Kuhn merged patch set 5 03/17/13, 21:20