Review TYPO3_6-0 Merged

18992[BUGFIX] Fix PHP warning in BackendUtility::lockRecords

Christian Kuhn CR +2 V +2 Easy +17 −15 updated 06/03/13, 20:49

Commit message

This methods triggers a warning "Illegal String offset"
with PHP 5.4, because $GLOBALS['BE_USER']->user['uid'] is accessed
even if a user is not logged in.

Additionally a delete query is executed in this case which
does not make sense at all.

Properly check if a user is logged in before executing any
functionality in this method.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Files 1

Review log 2

  1. Christian Kuhn commented on patch set 1 V 0 03/17/13, 21:29

    by team member; Looks good to me, approved
  2. Christian Kuhn merged patch set 2 03/17/13, 21:29