19194[BUGFIX] Copy and move folders between storages is broken
Commit message
Review
-
Code review CR +2
- Andreas Wolf +2
-
Verified V +2
- Andreas Wolf +2
Files 5
- typo3/sysext/core/Classes/Resource/Driver/AbstractDriver.php+31 −2
- typo3/sysext/core/Classes/Resource/Driver/LocalDriver.php+26 −0
- typo3/sysext/core/Classes/Resource/Folder.php+2 −2
- typo3/sysext/core/Classes/Resource/ResourceStorage.php+9 −14
- typo3/sysext/core/Classes/Utility/File/ExtendedFileUtility.php+8 −0
Review log 11
-
Fabien Udriot commented on patch set 1 03/23/13, 11:21
Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 03/23/13, 11:21
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7872/ : SUCCESS -
Andreas Wolf uploaded patch set 3 03/23/13, 11:21
-
Alexander Opitz commented on patch set 2 03/23/13, 11:21
Fails; Looks good to me, but someone else must approve With PHP 5.4.6-1ubuntu1.2 I get Segmentation Faults with this patch. The SegFault is coused by typo3/sysext/core/Classes/Resource/ResourceStorage.php:1368 for moving Files and typo3/sysext/core/Classes/Resource/ResourceStorage.php:1419 for copying files. It can be resolved by changing if ($sourceStorage == $this) { into if ($sourceStorage === $this) { -
Fabien Udriot commented on patch set 2 03/23/13, 11:21
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 2 03/23/13, 11:21
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7887/ : SUCCESS -
Mr. Jenkins commented on patch set 3 03/23/13, 11:21
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7896/ : SUCCESS -
Nicole Hummel uploaded patch set 2 03/23/13, 11:21
-
Nicole Hummel commented on patch set 2 03/23/13, 11:21
Moved the exception to the abstractDriver. So the exception is thrown as before but other drivers are not broken. -
Andreas Wolf commented on patch set 3 V 0 03/23/13, 11:21
by team member; Looks good to me, approved Fixed comments; merging this after my +2 (based on the +1 by Fabien) The issue Alexander mentioned is fixed in a different patch, to better document the issue. -
Andreas Wolf merged patch set 4 03/23/13, 11:21