Review main Merged

19198[BUGFIX] Subfolders must use the identifier as identifier

Georg Ringer CR +2 V +2 Easy +2 −5 updated 06/03/13, 20:49

Commit message

Currently subfolders don't use the identifier correctly as the name is
used instead. This doesn't really matter if you got a folder structure
anyway but dealing with different identifiers leads to troubles.

createFolderObject() will create a new Folder object which then has the
identifier set wrong.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Alexander Opitz +1
    • Tom +1
  • Verified V +2
    • Georg Ringer +2
    • Alexander Opitz +1

Files 1

Review log 9

  1. Andreas Wolf uploaded patch set 2 03/23/13, 18:34

  2. Tom commented on patch set 2 03/23/13, 18:34

    Looks good to me, but someone else must approve
  3. Alexander Opitz commented on patch set 1 03/23/13, 18:34

    Does this also resolve the TODO entry some lines above the change?
  4. Alexander Opitz commented on patch set 2 03/23/13, 18:34

    Verified; Looks good to me, but someone else must approve
  5. Georg Ringer commented on patch set 1 03/23/13, 18:34

    lol yes I think so ;)
  6. Georg Ringer commented on patch set 2 V 0 03/23/13, 18:34

    by team member; Looks good to me, approved
  7. Mr. Jenkins commented on patch set 1 03/23/13, 18:34

  8. Mr. Jenkins commented on patch set 2 03/23/13, 18:34

  9. Georg Ringer merged patch set 3 03/23/13, 18:34