Review main Merged

19200[BUGFIX] Warning empty $GLOBALS['TCA'] in rootline utility

Christian Kuhn CR +2 V +2 Easy +8 −9 updated 06/03/13, 20:49

Commit message

The TCA refactoring of issue #45767 introduced a warning in the
rootline utility: Rootline resolving is called by determineID in
index_ts. At this point in bootstrap the TCA was not loaded yet.
The patch just moves the TCA includes prior to determineID.

Warning: This leads to an earlier execution of ext_tables.php if
caches are empty. 6.0 did that too, it called includeTca()
in RootlineUtility to circumvent the same issue, the current patch
just solves the issue in a cleaner way. But still, this might lead
to problems if ext_tables.php code relies for example on the setup
done by determineID or the other code in between. The risk this
breaks something is pretty low, though.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 1